Skip to content

[Feature] Rename Auto Crop zoom mode — it is cover-zoom, not a crop #1523

Closed as not planned

Description

@selmant

What problem does this solve?

Player zoom mode Auto Crop is cover-zoom: it scales the coded frame to fill the window and clips overflow (BoxFit.cover / resizeAspectFill). It does not detect or remove encoded letterbox bars. The name already oversells what it does.

Proposed solution

Copy-only rename of the zoom-mode label and description so it is clearly fill/cover zoom, not bar detection.

Do not change zoom behavior.

Surfaces that say Auto Crop today:

  • lib/l10n/app_en.arb — autoCrop, settingsPlayerZoomDescription
  • Settings → Video playback → Player zoom mode
  • Player OSD zoom cycle / toast (l10n.autoCrop)
  • tvOS ZoomMode raw value / displayName ("Auto Crop")
  • iOS / macOS zoom wire (autoCrop, Auto Crop)

Leave the ZoomMode.autoCrop enum name unless a follow-up wants a code rename. English source first; Weblate already translates autoCrop.

Agree the new English label before shipping it.

Platform

All / Not platform-specific

Alternatives considered

  • Keep Auto Crop. The current name is already wrong.
  • Rename the enum (autoCrop → fill / cover). More churn than this issue needs.

Additional context

Related closed: #858 (Auto Crop preference not applying). That was behavior, not naming.

Activity

  1. changed the title [-][Feature] Rename Auto Crop zoom mode so it is not confused with Crop black bars[/-] [+][Feature] Rename Auto Crop zoom mode — it is cover-zoom, not a crop[/+] on Sep 12, 2026
  2. github-actions commented on Sep 27, 2026

    @github-actions
    Contributor

    This issue has had no activity for 14 days, so it has been marked Stale. If it's still happening, please reply with anything we are missing, a screenshot for a UI problem, or a diagnostic report for a playback one. See Collecting Logs for how to capture a report.

    Any comment removes the label and reopens the clock. Without one this will be closed in 7 days.

  3. github-actions commented on Oct 4, 2026

    @github-actions
    Contributor

    Closing this as inactive, since there has been no response for 21 days. That's not a judgement on the report, we simply can't reproduce or track something with no further information.

    If you run into this again, comment here with the details and we will reopen it. A new issue isn't necessary.

  4. added 2 commits that reference this issue on Oct 14, 2026
    11bfc14
    5ad94f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions