Replace Details screen loading skeletons with delayed Moonfin animation - #1541
Closed
clau-bucur wants to merge 2 commits into
Closed
clau-bucur wants to merge 2 commits into
clau-bucur wants to merge 2 commits into
Conversation
Use the configured loading animation across all platforms and detail styles Show it only after 600 ms, and display details immediately when ready
✅ Build SuccessfulAll platform builds and tests passed. You can download the test artifacts below. Tests ✅ 2623 passed, analyzer clean
|
Contributor
Author
|
Nevermind, I see the skeleton approach was a recently introduced intentional behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Opening a details page briefly flashed skeleton placeholders that looked like ghost controls and didn’t match the final layout. This replaces them with Moonfin’s existing loading animation after 600 ms, avoiding distracting flashes on fast loads.
Use the configured Moonfin loading animation across all platforms and detail styles.
Show it only after 600 ms, and display details immediately when ready
Type of Change
Changes Made
Platform
Testing
Describe how this change was tested.
Test Steps
Screenshots (if applicable)
Before fix:
https://github.com/user-attachments/assets/fe142cde-5974-406d-8d4f-a3777d9ca6ed
After fix:
https://github.com/user-attachments/assets/09a2f3df-ad33-41a6-b84e-5b6cfe1b4e4b
Checklist