Skip to content

Replace Details screen loading skeletons with delayed Moonfin animation - #1541

Closed
clau-bucur wants to merge 2 commits into
Moonfin-Client:mainfrom
clau-bucur:fix/details-loading-transition
Closed

clau-bucur wants to merge 2 commits into
Moonfin-Client:mainfrom
clau-bucur:fix/details-loading-transition

Conversation

@clau-bucur

Copy link
Copy Markdown
Contributor

Pull Request

Summary

Opening a details page briefly flashed skeleton placeholders that looked like ghost controls and didn’t match the final layout. This replaces them with Moonfin’s existing loading animation after 600 ms, avoiding distracting flashes on fast loads.

Use the configured Moonfin loading animation across all platforms and detail styles.
Show it only after 600 ms, and display details immediately when ready

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • UI/UX update
  • Documentation update
  • Build/CI change
  • Other (describe):

Changes Made

  • Replaced details skeleton placeholders with Moonfin’s existing loading animation across all platforms and detail styles.
  • Added a 600 ms delay before showing the animation; details appear immediately when ready.
  • Preserved animation preferences, including appearance, size, speed, position, and “None.”
  • Added tests covering timing, rebuilds, dismissal, and animation settings.

Platform

  • Android
  • Android TV
  • iOS
  • tvOS
  • Web
  • macOS
  • Windows
  • Linux
  • All / Shared code

Testing

Describe how this change was tested.

  • Tested on emulator / simulator
  • Tested on physical device - Android TV
  • Manual testing completed
  • Not tested (explain why):

Test Steps

  1. Navigate to a "Since you watched" from online source Home Screen row (using this row type because this generates the noticeable ghosting issue when opening the details screen)
  2. Open the selected card to display the details screen
  3. There's a brief moment when a "template screen" is shown then the screen layout changes completely to accomodate the selected item details screen.

Screenshots (if applicable)

Before fix:
https://github.com/user-attachments/assets/fe142cde-5974-406d-8d4f-a3777d9ca6ed

After fix:
https://github.com/user-attachments/assets/09a2f3df-ad33-41a6-b84e-5b6cfe1b4e4b

Checklist

  • Code builds successfully
  • Code follows project style and conventions
  • No unnecessary commented-out code
  • No new warnings introduced

Use the configured loading animation across all platforms and detail styles
Show it only after 600 ms, and display details immediately when ready
@github-actions github-actions Bot added All Performance This doesn't seem right UI labels Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

✅ Build Successful

All platform builds and tests passed. You can download the test artifacts below.

Tests ✅ 2623 passed, analyzer clean

Platform Status Artifact
Android ✅ Passed Moonfin_Android_v* + Moonfin_AndroidTV_v*
iOS ✅ Passed Moonfin_iOS_v*_unsigned.ipa
macOS ✅ Passed Moonfin_macOS_v*.dmg
tvOS ✅ Passed Moonfin_tvOS_v*_unsigned.ipa
Windows x64 ✅ Passed Moonfin_Windows_v*.exe
Windows ARM64 ✅ Passed Moonfin_WindowsARM64_v*.exe
Linux x64 ✅ Passed Moonfin_Linux_v* (deb/rpm/AppImage/snap/flatpak/tar.gz)
Linux ARM64 ✅ Passed Moonfin_LinuxARM64_v* (deb/rpm/AppImage/snap/flatpak/tar.gz)
Property Value
Commit e3d49e2
Workflow run Build #1460

@clau-bucur

Copy link
Copy Markdown
Contributor Author

Nevermind, I see the skeleton approach was a recently introduced intentional behavior.

@clau-bucur clau-bucur closed this Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

All Performance This doesn't seem right UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant