Skip to content

Feat: pest 5 - #79

Merged
MrPunyapal merged 3 commits into
mainfrom
feat/pest-5
Jul 19, 2026
Merged

MrPunyapal merged 3 commits into
mainfrom
feat/pest-5

Conversation

@MrPunyapal

@MrPunyapal MrPunyapal commented Jul 19, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Updated minimum supported PHP version to 8.4.
    • Upgraded Pest and PHPUnit development tooling to newer major versions.
    • Updated static analysis tooling to use the latest PestPHP integration.
    • Refined automated code-style rules for Pest tests.
    • Adjusted CI test runs to execute against PHP 8.4.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: bb9a9cae-4c6f-4755-bdb9-4ec1136e852f

📥 Commits

Reviewing files that changed from the base of the PR and between dae190d and 49764e1.

📒 Files selected for processing (2)
  • .github/workflows/tests.yml
  • rector.php
🚧 Files skipped from review as they are similar to previous changes (1)
  • rector.php

📝 Walkthrough

Walkthrough

The project now targets PHP 8.4, Pest 5, and PHPUnit 13. PHPStan uses the Pest PHPStan plugin extension, Rector targets PHP 8.4 with the updated Pest coding-style set, and the test workflow runs on PHP 8.4.

Changes

PHP and Pest tooling upgrade

Layer / File(s) Summary
Package and runtime constraints
composer.json, .github/workflows/tests.yml
Laravel keyword metadata, the PHP requirement, Pest plugins, Pest, PHPUnit, and the test workflow’s PHP version were updated.
Analysis and Rector configuration
phpstan.neon, rector.php
PHPStan now references the Pest PHPStan plugin extension, and Rector targets PHP 8.4 using PestSetList::CODING_STYLE from the updated namespace.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly signals the main change: upgrading to Pest 5.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pest-5

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 PHPStan (2.2.5)

PHPStan was skipped because the config uses disallowed bootstrapFiles, bootstrapFile, or includes directives.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
rector.php (1)

19-20: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Update Rector configuration to target PHP 8.4.

Since the project's minimum PHP requirement was updated to ^8.4 in composer.json, Rector should be configured to target PHP 8.4 as well. This ensures Rector applies PHP 8.4 improvements and doesn't incorrectly downgrade PHP 8.4 syntax back to PHP 8.3.

🛠️ Proposed fix
-    ->withPhpSets(php83: true)
-    ->withPhpVersion(PhpVersion::PHP_83)
+    ->withPhpSets(php84: true)
+    ->withPhpVersion(PhpVersion::PHP_84)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@rector.php` around lines 19 - 20, Update the Rector configuration’s PHP
target from 8.3 to 8.4 in the withPhpSets and withPhpVersion calls, using the
corresponding PHP 8.4 version constant so Rector matches the project’s minimum
supported PHP version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@composer.json`:
- Line 27: Update the PHP version in the CI workflow matrix from 8.3 to 8.4 so
it matches the composer.json requirement. Preserve the existing workflow matrix
structure and all other test configuration.

---

Outside diff comments:
In `@rector.php`:
- Around line 19-20: Update the Rector configuration’s PHP target from 8.3 to
8.4 in the withPhpSets and withPhpVersion calls, using the corresponding PHP 8.4
version constant so Rector matches the project’s minimum supported PHP version.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8e4890c9-5ced-414a-8341-b565512e5483

📥 Commits

Reviewing files that changed from the base of the PR and between cf612a6 and dae190d.

⛔ Files ignored due to path filters (1)
  • composer.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • composer.json
  • phpstan.neon
  • rector.php

Comment thread composer.json
@MrPunyapal
MrPunyapal merged commit e11de82 into main Jul 19, 2026
2 checks passed
@MrPunyapal
MrPunyapal deleted the feat/pest-5 branch July 19, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant