Frame rendering rework and fixes#1995
Merged
Merged
Conversation
covers1624
reviewed
Apr 16, 2026
| var quads = bakedQuads.get(mask); | ||
| if (quads == null) { | ||
| quads = generateQuads(mask); | ||
| bakedQuads.put(mask, quads); |
Collaborator
There was a problem hiding this comment.
You may be able to hit a CME here if 2 threads both generate a model at the same time.
You probably need the classic double sync latch.
This issue is probably present for your other model as well.
Owner
Author
There was a problem hiding this comment.
Yup, discovered this a few hours ago. A sync block around put fixes it. Or i can pre-bake the map at construction.
MrTJP
force-pushed
the
feature/movement-rework
branch
from
f49171f to
f582e8b
Compare
MrTJP
force-pushed
the
feature/movement-rework
branch
from
134cf16 to
5f83535
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICCBlockRendererin Frame and Motor models (Fixes [Bug] Issues With Stacked Frame Systems #1984)