Skip to content

Adding some more land-use-change and globally-relevant history variables #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glemieux merged 13 commits into from
Feb 17, 2026
Merged

Adding some more land-use-change and globally-relevant history variables #1485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4fb1c64
resolve ecosystem-level fire fluxes by dist type, and add hist var fo…
ckoven Jul 14, 2025
10d02e0
fixed handoff to fire C flux BC out
ckoven Jul 29, 2025
d0d2f1c
added hist var for fire C loss from live fuels only
ckoven Jul 29, 2025
7ef58a8
added hist variable for 95th percentile height across patches
ckoven Jul 14, 2025
f96296d
added and subtracted some history vars
ckoven Sep 10, 2025
bd40d25
added units to grazing term in coment
ckoven Sep 26, 2025
641a2cf
cleaning up some comments
ckoven Oct 10, 2025
52d3b65
merged main and resolved conflicts
ckoven Feb 3, 2026
72e1b74
add site level disturbance index for burn flux restart
glemieux Feb 8, 2026
068cabf
add missing disturbance index init at top of loop
glemieux Feb 8, 2026
b68d600
correct registration vtype
glemieux Feb 8, 2026
632a127
update TransNewLitterFlux to avoid zero index call to burn flux array
glemieux Feb 8, 2026
2680f31
move burned mass calculation within fire disturbance type into dcmpy …
glemieux Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 32 additions & 24 deletions biogeochem/EDPatchDynamicsMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,8 +1134,8 @@ subroutine spawn_patches( currentSite, bc_in )

endif

currentSite%mass_balance(el)%burn_flux_to_atm = &
currentSite%mass_balance(el)%burn_flux_to_atm + &
currentSite%mass_balance(el)%burn_flux_to_atm(i_disturbance_type) = &
currentSite%mass_balance(el)%burn_flux_to_atm(i_disturbance_type) + &
leaf_burn_frac * leaf_m * nc%n

! This term increments the loss flux from surviving trees
Expand Down Expand Up @@ -2042,7 +2042,10 @@ subroutine TransLitterNewPatch(currentSite, &


if (debug) then
burn_flux0 = site_mass%burn_flux_to_atm
burn_flux0 = 0._r8
if (dist_type .gt. 0) then
burn_flux0 = site_mass%burn_flux_to_atm(dist_type)
end if
litter_stock0 = curr_litt%GetTotalLitterMass()*currentPatch%area + &
new_litt%GetTotalLitterMass()*newPatch%area
end if
Expand All @@ -2051,20 +2054,17 @@ subroutine TransLitterNewPatch(currentSite, &
frac_burnt = 0.0_r8
if (dist_type == dtype_ifire .and. currentPatch%fire == 1) then
frac_burnt = currentPatch%fuel%frac_burnt(c)
burned_mass = curr_litt%ag_cwd(c) * patch_site_areadis * frac_burnt
site_mass%burn_flux_to_atm(dist_type) = site_mass%burn_flux_to_atm(dist_type) + burned_mass
end if

! Transfer above ground CWD
donatable_mass = curr_litt%ag_cwd(c) * patch_site_areadis * &
(1._r8 - frac_burnt)

burned_mass = curr_litt%ag_cwd(c) * patch_site_areadis * &
frac_burnt

new_litt%ag_cwd(c) = new_litt%ag_cwd(c) + donatable_mass*donate_m2
curr_litt%ag_cwd(c) = curr_litt%ag_cwd(c) + donatable_mass*retain_m2

site_mass%burn_flux_to_atm = site_mass%burn_flux_to_atm + burned_mass

! Transfer below ground CWD (none burns)
do sl = 1,currentSite%nlevsoil
donatable_mass = curr_litt%bg_cwd(c,sl) * patch_site_areadis
Expand All @@ -2074,24 +2074,22 @@ subroutine TransLitterNewPatch(currentSite, &

enddo

frac_burnt = 0.0_r8
if (dist_type == dtype_ifire .and. currentPatch%fire == 1) then
frac_burnt = currentPatch%fuel%frac_burnt(fuel_classes%dead_leaves())
end if

do dcmpy=1,ndcmpy

frac_burnt = 0.0_r8
if (dist_type == dtype_ifire .and. currentPatch%fire == 1) then
frac_burnt = currentPatch%fuel%frac_burnt(fuel_classes%dead_leaves())
burned_mass = curr_litt%leaf_fines(dcmpy) * patch_site_areadis * frac_burnt
site_mass%burn_flux_to_atm(dist_type) = site_mass%burn_flux_to_atm(dist_type) + burned_mass
end if

! Transfer leaf fines
donatable_mass = curr_litt%leaf_fines(dcmpy) * patch_site_areadis * &
(1._r8 - frac_burnt)

burned_mass = curr_litt%leaf_fines(dcmpy) * patch_site_areadis * &
frac_burnt

new_litt%leaf_fines(dcmpy) = new_litt%leaf_fines(dcmpy) + donatable_mass*donate_m2
curr_litt%leaf_fines(dcmpy) = curr_litt%leaf_fines(dcmpy) + donatable_mass*retain_m2

site_mass%burn_flux_to_atm = site_mass%burn_flux_to_atm + burned_mass

! Transfer root fines (none burns)
do sl = 1,currentSite%nlevsoil
Expand Down Expand Up @@ -2122,13 +2120,21 @@ subroutine TransLitterNewPatch(currentSite, &
! EDMainMod start triggering.
! --------------------------------------------------------------------------
if (debug) then
burn_flux1 = site_mass%burn_flux_to_atm
burn_flux1 = 0._r8
if (dist_type .gt. 0) then
burn_flux1 = site_mass%burn_flux_to_atm(dist_type)
end if
litter_stock1 = curr_litt%GetTotalLitterMass()*remainder_area + &
new_litt%GetTotalLitterMass()*newPatch%area
error = (litter_stock1 - litter_stock0) + (burn_flux1-burn_flux0)
if(abs(error)>1.e-8_r8) then
write(fates_log(),*) 'non trivial carbon mass balance error in litter transfer'
write(fates_log(),*) 'abs error: ',error
write(fates_log(),*) 'dist type: ', dist_type
write(fates_log(),*) 'litt stock 1, 0: ', litter_stock1, litter_stock0
write(fates_log(),*) 'area: rem, new ', remainder_area, newPatch%area
write(fates_log(),*) 'burn flux 1, 0: ', burn_flux1, burn_flux0, sum(site_mass%burn_flux_to_atm)
write(fates_log(),*) 'burn flux: ', site_mass%burn_flux_to_atm
call endrun(msg=errMsg(sourcefile, __LINE__))
end if
end if
Expand Down Expand Up @@ -2301,7 +2307,7 @@ subroutine fire_litter_fluxes(currentSite, currentPatch, &
donatable_mass*retain_m2*dcmpy_frac
end do

site_mass%burn_flux_to_atm = site_mass%burn_flux_to_atm + burned_mass
site_mass%burn_flux_to_atm(dtype_ifire) = site_mass%burn_flux_to_atm(dtype_ifire) + burned_mass

call set_root_fraction(currentSite%rootfrac_scr, pft, currentSite%zi_soil, &
bc_in%max_rooting_depth_index_col)
Expand Down Expand Up @@ -2363,7 +2369,7 @@ subroutine fire_litter_fluxes(currentSite, currentPatch, &
donatable_mass = donatable_mass * (1.0_r8-currentCohort%fraction_crown_burned)
burned_mass = num_dead_trees * SF_val_CWD_frac_adj(c) * bstem * &
currentCohort%fraction_crown_burned
site_mass%burn_flux_to_atm = site_mass%burn_flux_to_atm + burned_mass
site_mass%burn_flux_to_atm(dtype_ifire) = site_mass%burn_flux_to_atm(dtype_ifire) + burned_mass
endif
new_litt%ag_cwd(c) = new_litt%ag_cwd(c) + donatable_mass * donate_m2
curr_litt%ag_cwd(c) = curr_litt%ag_cwd(c) + donatable_mass * retain_m2
Expand Down Expand Up @@ -2768,7 +2774,8 @@ subroutine landusechange_litter_fluxes(currentSite, currentPatch, &
donatable_mass*retain_m2*dcmpy_frac
end do

site_mass%burn_flux_to_atm = site_mass%burn_flux_to_atm + burned_mass
site_mass%burn_flux_to_atm(dtype_ilandusechange) = &
site_mass%burn_flux_to_atm(dtype_ilandusechange) + burned_mass

call set_root_fraction(currentSite%rootfrac_scr, pft, currentSite%zi_soil, &
bc_in%max_rooting_depth_index_col)
Expand Down Expand Up @@ -2828,8 +2835,8 @@ subroutine landusechange_litter_fluxes(currentSite, currentPatch, &
burned_mass = num_dead_trees * SF_val_CWD_frac(c) * bstem * &
EDPftvarcon_inst%landusechange_frac_burned(pft)

site_mass%burn_flux_to_atm = site_mass%burn_flux_to_atm + burned_mass

site_mass%burn_flux_to_atm(dtype_ilandusechange) = &
site_mass%burn_flux_to_atm(dtype_ilandusechange) + burned_mass
else ! all other pools can end up as timber products or burn or go to litter
donatable_mass = donatable_mass * (1.0_r8-EDPftvarcon_inst%landusechange_frac_exported(pft)) * &
(1.0_r8-EDPftvarcon_inst%landusechange_frac_burned(pft))
Expand All @@ -2841,7 +2848,8 @@ subroutine landusechange_litter_fluxes(currentSite, currentPatch, &
woodproduct_mass = num_dead_trees * SF_val_CWD_frac(c) * bstem * &
EDPftvarcon_inst%landusechange_frac_exported(pft)

site_mass%burn_flux_to_atm = site_mass%burn_flux_to_atm + burned_mass
site_mass%burn_flux_to_atm(dtype_ilandusechange) = &
site_mass%burn_flux_to_atm(dtype_ilandusechange) + burned_mass

! Amount of trunk mass exported off site [kg/m2]
elflux_diags%exported_harvest = elflux_diags%exported_harvest + &
Expand Down
2 changes: 1 addition & 1 deletion main/ChecksBalancesMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ subroutine CheckIntegratedMassPools(site)
ibal%iflux_litter = ibal%iflux_litter + &
tot_litter_input - &
(site_mass%frag_out*area_inv - ediag%tot_seed_turnover) - &
(site_mass%burn_flux_to_atm*area_inv - ediag%burned_liveveg)
(sum(site_mass%burn_flux_to_atm(:))*area_inv - ediag%burned_liveveg)


ediag%err_liveveg = ibal%iflux_liveveg - ibal%state_liveveg
Expand Down
10 changes: 5 additions & 5 deletions main/EDMainMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,9 +917,8 @@ subroutine ed_update_site( currentSite, bc_in, bc_out, is_restarting )
bc_out%seed_c_si = bc_out%seed_c_si * g_per_kg * AREA_INV

! Set boundary condition to HLM for carbon loss to atm from fires and grazing
! [kgC/ha/day]*[ha/m2]*[day/s] = [kg/m2/s]

bc_out%fire_closs_to_atm_si = site_cmass%burn_flux_to_atm * area_inv * days_per_sec
! [kgC/ha/day]*[ha/m2]*[day/s] = [kg/m2/s]
bc_out%fire_closs_to_atm_si = sum(site_cmass%burn_flux_to_atm(:)) * area_inv * days_per_sec
bc_out%grazing_closs_to_atm_si = site_cmass%herbivory_flux_out * area_inv * days_per_sec

end subroutine ed_update_site
Expand Down Expand Up @@ -1009,9 +1008,10 @@ subroutine TotalBalanceCheck (currentSite, call_index, is_restarting )
site_mass%flux_generic_in + &
site_mass%patch_resize_err


flux_out = sum(site_mass%wood_product_harvest(:)) + &
sum(site_mass%wood_product_landusechange(:)) + &
site_mass%burn_flux_to_atm + &
sum(site_mass%burn_flux_to_atm(:)) + &
site_mass%seed_out + &
site_mass%flux_generic_out + &
site_mass%frag_out + &
Expand Down Expand Up @@ -1045,7 +1045,7 @@ subroutine TotalBalanceCheck (currentSite, call_index, is_restarting )
write(fates_log(),*) 'wood_product_harvest: ',site_mass%wood_product_harvest(:)
write(fates_log(),*) 'wood_product_landusechange: ',site_mass%wood_product_landusechange(:)
write(fates_log(),*) 'error from patch resizing: ',site_mass%patch_resize_err
write(fates_log(),*) 'burn_flux_to_atm: ',site_mass%burn_flux_to_atm
write(fates_log(),*) 'burn_flux_to_atm: ',site_mass%burn_flux_to_atm(:)
write(fates_log(),*) 'seed_out: ',site_mass%seed_out
write(fates_log(),*) 'flux_generic_out: ',site_mass%flux_generic_out
write(fates_log(),*) 'frag_out: ',site_mass%frag_out
Expand Down
6 changes: 3 additions & 3 deletions main/EDTypesMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ module EDTypesMod

real(r8) :: wood_product_landusechange(maxpft) ! Total mass exported as wood product from land use change [kg/site/day]

real(r8) :: burn_flux_to_atm ! Total mass burned and exported to the atmosphere [kg/site/day]
real(r8) :: burn_flux_to_atm(n_dist_types) ! Total mass burned and exported to the atmosphere [kg/site/day]

real(r8) :: flux_generic_in ! Used for prescribed or artificial input fluxes
! and initialization [kg/site/day]
Expand All @@ -308,7 +308,7 @@ module EDTypesMod
! due to re-sizing patches when area math starts to lose
! precision

real(r8) :: herbivory_flux_out ! loss of element due to grazing (and/or browsing) by herbivores
real(r8) :: herbivory_flux_out ! loss of element due to grazing (and/or browsing) by herbivores [kg/site/day]

contains

Expand Down Expand Up @@ -717,7 +717,7 @@ subroutine ZeroMassBalFlux(this)
this%frag_out = 0._r8
this%wood_product_harvest(:) = 0._r8
this%wood_product_landusechange(:) = 0._r8
this%burn_flux_to_atm = 0._r8
this%burn_flux_to_atm(:) = 0._r8
this%flux_generic_in = 0._r8
this%flux_generic_out = 0._r8
this%patch_resize_err = 0._r8
Expand Down
Loading