allocate space to disturbance_rates in the restart file#1588
Open
rgknox wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
For FATES variables that are restarted, and are longer than column level (ie most of our variables), we end up folding all of these variables into a restart vector of one prescribed length. We call this the cohort dimension, but it really is a catch all for any variable that requires more space than the site/column. So, the size of this vector must be the largest possible vector that we need to remember. We have some tricks to get around making this vector super large, one of them is to actually define multiple copies of the variable with name extensions.
But its very important when we add new restart variables that are big, that we make sure we allocate restart space. Its hard to know which dimensions are going to require the most restart space, because many of things are modified by the user, and contextual to the type of run.
This set of changes makes sure that we allocate enough restart space for "disturbance_rates" which is a 3D variable (n_landuse_cats x n_landuse_cats * n_dist_type = 5 * 5 * 4 = 100)
I came across this while reviewing one of @mpaiao 's old PRs.
cc: @mvdebolskiy @maritsandstad @JessicaNeedham @rosiealice
(I'm not sure if this is affecting noresm nocomp lu runs, seems possible though)
Collaborators:
@mpaiao
Expectation of Answer Changes:
Description of generative AI usage (as necessary)
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: