Add centralised workspace dependencies#544
Merged
Merged
Conversation
AkshatRai07
changed the title
felixhekhorn
added
rust
felixhekhorn
left a comment
felixhekhorn
left a comment
Collaborator
There was a problem hiding this comment.
this line should ensure that this change is still compatible with the version script, right? if yes, I think we can add the additional comment and merge
Collaborator
Author
|
Thanks for pointing it out, we needed to change that file. Now when bump-versions is ran, it changes the workspace version of the project, as well as that of the internal dependencies. Previously the internal dependencies version was changed in crates, but since there is no version in crate level, file is changed to workspace level. |
felixhekhorn
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A prerequisite for #537.
Cargo.toml, and all crates point to that.