Add msrv.yml#545
Conversation
|
The workflow failed. We must bump the version to |
felixhekhorn
left a comment
There was a problem hiding this comment.
looks good to me
- as said on the other side we should (if possible) synchronize with PineAPPL; setting a lower minimum is always fine
- can you please remind me what "Rust edition" is? is it relevant for us?
|
I am not well versed with version of languages and stuff, but all rust crates require atleast some version for compilation. In our case, there is this So one must upgrade rust to 1.81 or later in order to work with the ecosystem. |
|
For Rust Editions, Rust has a philosophy to keep the code always backwards compatible. So if there are some breaking changes, like introduction of a new keyword which may break code, they are released in Editions. We can check what changes we should do in the code if we want to avoid breaking changes by doing We should bump the Edition, because it's not costing us much. And it is better in code auditing and readability. For eg. |
|
Reason for the file changes:
|
felixhekhorn
left a comment
There was a problem hiding this comment.
Please add a Changelog entry mentioning version+edition
This is prerequisite for #537.
msrv.ymlfile to workflows.1.85.0.