fix: route known text directly with safe Ray admission - #2454
Open
jioffe502 wants to merge 6 commits into
Open
Conversation
jioffe502
force-pushed
the
jioffe502/graph-aware-batch-admission
branch
from
August 13, 2026 08:19
fcc2c46 to
4509cfd
Compare
jioffe502
force-pushed
the
jioffe502/graph-aware-batch-admission
branch
from
August 13, 2026 18:50
4509cfd to
80f6f93
Compare
jioffe502
marked this pull request as ready for review
August 13, 2026 19:12
Contributor
Greptile SummaryThe PR routes known text inputs directly through
|
| Filename | Overview |
|---|---|
| nemo_retriever/src/nemo_retriever/graph/executor.py | Extends actor-pool bounds handling and shared CPU admission to reserve capacity for source reads and other task work. |
| nemo_retriever/src/nemo_retriever/graph/ingestor_runtime.py | Builds a direct text extraction graph and derives a bounded automatic TxtSplitActor pool from available CPUs. |
| nemo_retriever/src/nemo_retriever/ingestor/branch_extraction.py | Passes extraction mode into tuning and includes multi-dataset schema-normalization capacity in shared preflight. |
| nemo_retriever/src/nemo_retriever/ingestor/graph_ingestor.py | Propagates the resolved extraction mode into batch node-override planning. |
| docs/docs/extraction/performance_guide.md | Documents direct text concurrency, normalization reservations, explicit-plan validation, and actor-pool tuple accounting. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
I[Known text inputs] --> G[Direct TxtSplitActor graph]
C[Cluster resources] --> P[Shared resource preflight]
R[Source-read reservation] --> P
N[Normalization reservation] --> P
O[Explicit and automatic pool settings] --> P
P --> A[Admitted actor concurrency]
A --> G
G --> S[Common post-extraction stages]
Reviews (8): Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." | Re-trigger Greptile
jioffe502
force-pushed
the
jioffe502/graph-aware-batch-admission
branch
from
August 13, 2026 19:16
80f6f93 to
55720e2
Compare
Signed-off-by: Jacob Ioffe <jioffe@nvidia.com>
Signed-off-by: Jacob Ioffe <jioffe@nvidia.com>
jioffe502
force-pushed
the
jioffe502/graph-aware-batch-admission
branch
from
August 14, 2026 16:16
97d7ed0 to
d1e7928
Compare
Collaborator
Author
|
check to see if this is fundamentally a router problem or if this is the right fix. |
Signed-off-by: Jacob Ioffe <jioffe@nvidia.com>
Signed-off-by: Jacob Ioffe <jioffe@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Known
.txtinputs are classified before graph construction, but the resolved text branch still used the genericMultiTypeExtractOperator, whose Ray actor pool defaulted to one worker. Batch admission also did not reserve CPU for schema-normalization tasks created after extraction branches were resolved.This PR routes known text directly through
TxtSplitActorand admits the complete resolved batch graph around its known actor and task requirements.What changes
TxtSplitActorgraph for known text inputs;MultiTypeExtractOperatorremains available forautoand other composite extraction paths.BatchTuningParamsandnode_overridesauthoritative; infeasible explicit plans fail before execution.(min, max)and(min, max, initial)Ray actor-pool tuples as requested capacity.Filesystem-reader capacity remains owned by the existing
source_cpu_reservationcontract. Normalization capacity is added without counting readers twice.Evidence
TxtSplitActorworkers plus 1 reader CPU; physical plan wasReadBinary -> TxtSplitCPUActor; 100/100 paths, 100 rows, 0 errors; Ray dataset completed in 3.12 sTxtSplitActorworkers; 10,000/10,000 paths produced exactly 75,065 rows with 0 errors; Ray dataset completed in 33.18 s and the public call completed in 76.42 s including worker-environment setupThe text changes improve extraction throughput. Embedding and the final store remain separate downstream bottlenecks for full BrowseComp ingestion.
Scope
Validation
main: focused suites passedReviewer focus
TextChunkParamsandsplit_config["text"]precedence?TxtSplitActorpool reduced around reader/task capacity while explicit overrides remain authoritative?