docs(api): resolve Sphinx roles and hide private API members (NVBug 6628858) - #2564
Open
kheiss-uwzoo wants to merge 3 commits into
Open
docs(api): resolve Sphinx roles and hide private API members (NVBug 6628858)#2564kheiss-uwzoo wants to merge 3 commits into
kheiss-uwzoo wants to merge 3 commits into
Conversation
…628858) The published API reference showed raw reST markup, stale import paths, and duplicate private symbols.
Remove the Python Sphinx-role converter from the docs PR and hide generated docstrings that still contain unresolved reST roles.
kheiss-uwzoo
marked this pull request as ready for review
August 19, 2026 22:34
Contributor
Greptile SummaryThe PR narrows the generated API reference to selected public NeMo Retriever surfaces and adjusts mkdocstrings defaults to hide private, inherited, and duplicate members.
|
| Filename | Overview |
|---|---|
| docs/docs/extraction/nemo-retriever-api-reference.md | Reorganizes the generated API section around explicit public objects and documented import paths. |
| docs/mkdocs.yml | Configures mkdocstrings to use the NeMo Retriever source tree and suppress private, inherited, and submodule members. |
Reviews (2): Last reviewed commit: "Merge branch 'main' into docs/6628858-ap..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:class:/:meth:markup on the API reference by converting roles at MkDocs build time._buffers,__all__, repeatedEmbedParams).Fixes NVBug 6628858.
Test plan
generate()/judge()show readable linked names instead of:class:text.EmbedParamsappears once atnemo_retriever.common.params.EmbedParams._buffers,_not_implemented,__all__) are absent.pre-draft: leakage, mkdocs --strict, ::a, ::p, ::r on the diff vs main
Base: upstream/main
Files: nemo-retriever-api-reference.md, mkdocs.yml, sphinx_roles.py
see [CTAs)see [on the API page; nonimOperatoron faq.md, overview.md, or multimodal-extraction.md. Script also flagged untracked leftovercustom-metadata.md, which is not in this diff.mkdocs.ymlandsphinx_roles.pyare docs-build files for this API-page fix.src/(95%). Code drift remains inretriever.pySphinx roles.Code drift (not in this docs PR):
nemo_retriever/src/nemo_retriever/graph/retriever.py:73still documentsnemo_retriever.params.EmbedParams;:645still documentsnemo_retriever.llm.clients.LiteLLMClient;:699still documentsnemo_retriever.llm.clients.judge.LLMJudge. The published page rewrites those roles at build time.