chore(openshell): upgrade supported version to 0.0.82#6726
Conversation
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Review Advisor — InformationalAdvisor assessment: Informational / high confidence Model lanes
Nemotron is a non-blocking second opinion. Its prose, findings, and E2E guidance do not change the primary assessment above and remain in workflow artifacts only. E2E guidanceAdvisory only: coverage and selector recommendations are non-authoritative. E2E / PR Gate independently computes and dispatches trusted jobs without consuming this output. Recommended coverage:
This is an automated, non-authoritative review. Findings are inputs to maintainer adjudication. Warnings and optional suggestions do not require a response or follow-up. A human maintainer makes the final merge decision. |
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage remains at 96%, unchanged from the branch. TypeScript / code-coverage/cliThe overall coverage in the branch remains at 79%, unchanged from the branch. Show a code coverage summary of the most impacted files.
Updated |
|
🌿 Preview your docs: https://nvidia-preview-pr-6726.docs.buildwithfern.com/nemoclaw |
E2E Target Results — ❌ Some tests failedRun: 29207131689
|
E2E Target Results — ✅ All requested tests passedRun: 29207131689
|
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
## Summary Extend the base-trusted installer parser so a separately reviewed dependency pin PR can add standalone sandbox binary identities as release data without authorizing operational installer changes. This is the remaining base-branch prerequisite for #6726 after #6778 landed. ## Changes - Parse `pinned_sandbox_build_version` as a strict literal digest-to-version case map before normalizing it as release data. - Require a unique SHA-256 per entry, literal `X.Y.Z` versions, a fail-closed default branch, and at least one identity for the selected release. - Bind `DEV_MIN_VERSION` to the same selected release as the installer tables and other stable selectors. - Add positive coverage for a v0.0.82 sandbox identity addition and negative coverage for control-flow, unknown-command, duplicate-digest, and malformed-version edits. The complete v0.0.82 upgrade tree passes this base-trusted checker against all three release manifests and all ten consumed archives. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [x] Tests added or updated for changed behavior - [ ] Existing tests cover changed behavior — justification: - [ ] Tests not applicable — justification: - [ ] Docs updated for user-facing behavior changes - [x] Docs not applicable — justification: this changes only the base-owned dependency verification boundary; active selectors remain on v0.0.72. - [x] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [x] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: author review confirmed only the fully parsed release-data function and literal selectors are normalized; all other installer text remains locked by the trusted template hash. - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## Verification - [x] PR description includes the DCO sign-off declaration and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run check:diff` passed when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — `npx vitest run test/installer-hash-check.test.ts` (67/67), `npm run build:cli`, `npm run typecheck`, and the base-trusted checker against #6726 - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: not applicable to this focused verifier grammar extension; normal hooks, typecheck, and focused integration coverage passed. - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Aaron Erickson <aerickson@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Security & Reliability** - Strengthened installer verification by adding trusted “sandbox build version” pin checks alongside existing checksum and command pin validation. - Installers now fail closed if sandbox build pins or development minimum version selectors are missing, malformed, inconsistent, or altered. - Updated trusted installer template expectations to improve detection of unauthorized changes and version drift. - **Testing** - Expanded installer-hash tests with new sandbox build mutation scenarios, including both allowed pin changes and multiple rejected tampering cases, plus development-version drift coverage. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Signed-off-by: Aaron Erickson <aerickson@nvidia.com>
Summary
This draft upgrades every stable NemoClaw OpenShell selector and consumed artifact from
0.0.72to stable0.0.82, including the #6379 credential-rewrite fix and OpenShell's multiline exec contract. Stablev0.0.82is verified at94cdd697c55aedb571f177ec13cfa54a8e213919, and the base-owned manifest and sandbox-build trust prerequisites landed in #6778 and #6779.The branch remains draft while exact-head CI/advisor review and the platform-specific runtime proofs below are incomplete.
Related Issue
Fixes #6379.
Changes
v0.0.72throughv0.0.82: 47 commits and 175 distinct changed paths. The finalv0.0.81..v0.0.82range contains 12 commits, 76 paths, and+7851/-983; release notes were treated as leads rather than proof.v0.0.82at94cdd697, its audited parentbb72d012, and successful producer run29260186856. The final tag delta is limited to the release-action bump.0.0.82.0.0.72references remain only where cleanup, fallback, or compatibility evidence requires them.docs/security/openshell-0.0.82-migration-review.md.CONNECT 503as unavailable TLS credential rewriting instead of a generic curl transport error.OPENSHELL_TLS_CA,OPENSHELL_TLS_CERT, andOPENSHELL_TLS_KEYif an entrypoint, exec, or connect child receives them.mcp status, real credential substitution, an authenticated MCP tool call, rotation/rebuild/removal behavior, and absence of literalopenshell:resolve:env:leakage.Release provenance
Type of Change
Quality Gates
Verification
Verifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablebash scripts/check-installer-hash.shpassed all three manifests and all ten consumed release archives against trustedmain;npx tsx scripts/checks/dependency-pins.ts,npm run build:cli, andnpm run typecheckpassed; the installer/trust suite passed 69/69 after its positive future-release fixture was refreshed.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: the macOS broad run executed 950 tests across 50 files (870 passed, 72 skipped, 8 failed). One stale installer fixture was fixed and its suite passed 69/69. Four failures require Linuxfcntl.F_SEAL_*; two timeout-sensitive files (auto-pair, sandbox exec) passed focused reruns; the older-branch OTLP test still exceeds the local 15-second budget. Authoritative exact-head Linux/platform CI is pending.npm run docsbuilds without warnings (doc changes only) — result: build completed with zero errors; existing unauthenticated-redirect and light-contrast warnings remain. Route/variant checks and targeted docs tests passed, and an independent docs-writer review required no further edits.Signed-off-by: Aaron Erickson aerickson@nvidia.com