-
Notifications
You must be signed in to change notification settings - Fork 759
Graph Safe Current Scaling Support for GroupedLinear Module/Ops + Fix CUBLAS GGEMM heuristics for Wgrad #3143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vthumbe1503
wants to merge
12
commits into
NVIDIA:main
Choose a base branch
from
vthumbe1503:nvfp4_and_fp8_current_scaling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+93
−33
Open
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bad0b2c
support in grouped linear and relevant tests
vthumbe1503 9af6df6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] bd0832c
Unecessary details remove
vthumbe1503 a163af3
fix grouped linear module's grouped tensor path
vthumbe1503 971160f
allow more current scaling use-cases.. block nvfp4+rht+single grouped…
vthumbe1503 cb57694
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f97ef20
some minor comment fixing
vthumbe1503 b195152
Merge branch 'nvfp4_and_fp8_current_scaling' of github.com:vthumbe150…
vthumbe1503 2770984
Merge branch 'main' into nvfp4_and_fp8_current_scaling
vthumbe1503 018e6e6
fix heuristics
vthumbe1503 4b9a2a0
Merge branch 'main' into nvfp4_and_fp8_current_scaling
vthumbe1503 808e83c
only dealyed scaling skip in failure comment
vthumbe1503 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to blanket skip these tests on Hopper even though they could run with FP8 current scaling.
Is that intentional for the CUDA graphed execution tests? Is there a reason why the implementation is not graph-safe, or was this just an oversight?