-
Notifications
You must be signed in to change notification settings - Fork 74
Add cuda_device_id placement knob for GPU decoders #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kvmto
wants to merge
3
commits into
NVIDIA:main
Choose a base branch
from
kvmto:decoder-gpu-pinning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| /******************************************************************************* | ||
| * Copyright (c) 2022 - 2026 NVIDIA Corporation & Affiliates. * | ||
| * All rights reserved. * | ||
| * * | ||
| * This source code and the accompanying materials are made available under * | ||
| * the terms of the Apache License 2.0 which accompanies this distribution. * | ||
| ******************************************************************************/ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <cuda_runtime_api.h> | ||
| #include <stdexcept> | ||
| #include <string> | ||
|
|
||
| namespace cudaq::qec::detail_affinity { | ||
|
|
||
| /// RAII: set the calling thread's CUDA device, restore the previous device on | ||
| /// scope exit. No-op for target < 0. Lib-private and header-only so it can be | ||
| /// reused by decoder implementation files without adding a public API. | ||
| /// | ||
| /// This guard is for threads that do NOT follow the one-thread-owns-one- | ||
| /// decoder persistent pin (e.g. the fresh worker spawned by decode_async). | ||
| class CudaDeviceGuard { | ||
| public: | ||
| explicit CudaDeviceGuard(int target) { | ||
| if (target < 0) | ||
| return; | ||
| int count = 0; | ||
| const cudaError_t count_status = cudaGetDeviceCount(&count); | ||
| if (count_status != cudaSuccess) | ||
| throw std::runtime_error( | ||
| "CudaDeviceGuard: cudaGetDeviceCount() failed for cuda_device_id " + | ||
| std::to_string(target) + ": " + cudaGetErrorString(count_status)); | ||
| if (target >= count) | ||
| throw std::runtime_error("cuda_device_id " + std::to_string(target) + | ||
| " is out of range: " + std::to_string(count) + | ||
| " CUDA device(s) visible"); | ||
| // If the current device is unreadable, skip restoration rather than | ||
| // restore to a guessed device; the set below still applies. | ||
| if (cudaGetDevice(&prev_) != cudaSuccess) | ||
| prev_ = -1; | ||
| cudaError_t err = cudaSetDevice(target); | ||
| if (err != cudaSuccess) | ||
| throw std::runtime_error("CudaDeviceGuard: cudaSetDevice(" + | ||
| std::to_string(target) + | ||
| ") failed: " + cudaGetErrorString(err)); | ||
| restore_ = (prev_ >= 0 && prev_ != target); | ||
| } | ||
| ~CudaDeviceGuard() { | ||
| if (restore_) | ||
| (void)cudaSetDevice(prev_); | ||
| } | ||
| CudaDeviceGuard(const CudaDeviceGuard &) = delete; | ||
| CudaDeviceGuard &operator=(const CudaDeviceGuard &) = delete; | ||
|
|
||
| private: | ||
| int prev_ = -1; | ||
| bool restore_ = false; | ||
| }; | ||
|
|
||
| } // namespace cudaq::qec::detail_affinity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on what I'm reading, the docs are saying to do this, but
libs/qec/unittests/test_decoders_yaml.cppflags this as invalid configuration. Am I missing something?