Allow a decoder to be constructed from a raw Stim DEM - #788
Draft
melody-ren wants to merge 1 commit into
Draft
Conversation
A decoder entry may name a Stim detector error model instead of the matrix form of the same model. The decoder is then constructed from the DEM text, which is the only construction a DEM-native decoder such as Chromobius accepts, and derives its own dimensions and observable mapping from it. The matrix keys become optional at the parser and the checks that compare against syndrome_size move to the constructed decoder; the matrix path is otherwise unchanged. The model text also reaches a nested global decoder through global_decoder_params, so trt_decoder can build Chromobius rather than handing it a parity check matrix it cannot use. Signed-off-by: Melody Ren <melodyr@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A workaround solution to enable Chromobius on the decoding server while the proper solution is being worked out.
A decoder entry may name a Stim detector error model instead of the matrix form of the same model. The decoder is then constructed from the DEM text, which is the only construction a DEM-native decoder such as Chromobius accepts, and derives its own dimensions and observable mapping from it. The matrix keys become optional at the parser and the checks that compare against syndrome_size move to the constructed decoder; the matrix path is otherwise unchanged.
The model text also reaches a nested global decoder through global_decoder_params, so trt_decoder can build Chromobius rather than handing it a parity check matrix it cannot use.