[SkipRecovery] Re-enable Parquet V2 encoding fixtures [fast-ut] [databricks] - #15852
Conversation
Signed-off-by: Allen Xu <allxu@nvidia.com>
There was a problem hiding this comment.
Pull request overview
This pull request re-enables five Parquet V2 “delta encoding” fixtures in the parquet-testing integration suite by removing their entries from the shared _xfail_files mapping now that upstream cuDF support is available. This restores GPU-vs-CPU parity coverage for those datasets under both native and Java parquet reader configurations.
Changes:
- Removed five
delta_*parquet-testing fixtures from_xfail_filesso they are no longer markedxfail. - Restored execution of those fixtures across both
_native_reader_confsand_java_reader_confsintest_parquet_testing_valid_files.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Greptile SummaryRe-enables CPU/GPU parity coverage for five Parquet V2 DELTA-encoding fixtures now supported by cuDF, while retaining an expected failure for DELTA_LENGTH_BYTE_ARRAY on Spark versions before 3.4.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (5): Last reviewed commit: "Merge branch 'main' into codex/skip-reco..." | Re-trigger Greptile |
…3501-parquet-v2 Signed-off-by: Allen Xu <allxu@nvidia.com>
|
build |
Signed-off-by: Allen Xu <allxu@nvidia.com>
Signed-off-by: Allen Xu <allxu@nvidia.com>
|
build |
JaCoCo production line coverage: +0 lines (measured:
delta-lake,shuffle-plugin,sql-plugin,udf-compiler; shim 350, vs nightly b19;delta-lakereport group is stub-only; Iceberg implementation not loaded/applicable)Contributes to NVIDIA/cudf#13501.
Description
Five Parquet V2 encoding fixtures remained xfailed after cuDF added the corresponding reader support in NVIDIA/cudf#13637, NVIDIA/cudf#14101, and NVIDIA/cudf#14590. The resolved cudf-spark JNI artifact embeds cuDF revision
c2c4e85881a52e93e042a59cf88b7633147760c2, which contains all three fixes.This change removes only those five fixture entries from
_xfail_files. The existingtest_parquet_testing_valid_filestest continues to compare CPU and GPU results under both native and Java reader configurations, recovering 10 test nodes. Other issue-linked xfails in the shared mapping are unchanged.Validation:
BUILD SUCCESS.10 passed, 86 deselected, 12 warnings in 7.90s.--runxfail:10 passed, 86 deselected, 12 warnings in 8.91s.parquet_testing_test.py:84 passed, 4 xfailed, 8 xpassed, 90 warnings in 36.49s.GpuFileGpuScanoccurrences and no CPU-fallback markers.AI assistance: The change was prepared with Codex assistance and reviewed by the author at commit
ab12239d371d07abdd300422230a81b3eebec0cabefore submission. The PR description was prepared with Codex assistance.Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance