-
Notifications
You must be signed in to change notification settings - Fork 303
[FEA] Add Iceberg fast test matrix [fast-ut] #15876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liurenjie1024
wants to merge
8
commits into
NVIDIA:main
Choose a base branch
from
liurenjie1024:ray/15875
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+865
−176
Open
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ddd2038
Add Iceberg fast test matrix
liurenjie1024 75bdb61
Merge remote-tracking branch 'upstream/main' into ray/15875
liurenjie1024 dfd72ac
Address Iceberg test matrix review feedback
liurenjie1024 843ae92
Clarify Iceberg matrix derivation
liurenjie1024 8521557
Honor Iceberg fast-run environment setting
liurenjie1024 dfbd4a3
Use JSON for the Iceberg version matrix
liurenjie1024 1ad5033
Use Scala 2.13 POM for Iceberg matrix validation
liurenjie1024 536c9c9
Test the Iceberg version matrix selector
liurenjie1024 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,206 @@ | ||
| { | ||
| "iceberg_versions": [ | ||
| { | ||
| "version": "1.6.1", | ||
| "upstream_minimums": { | ||
| "3.3": "3.3.4", | ||
| "3.4": "3.4.3", | ||
| "3.5": "3.5.1" | ||
| }, | ||
| "spark_versions": [ | ||
| { | ||
| "version": "3.3.4", | ||
| "supported": false, | ||
| "reason": "Iceberg GPU acceleration is not currently packaged for Spark 3.3.x" | ||
| }, | ||
| { | ||
| "version": "3.4.3", | ||
| "supported": false, | ||
| "reason": "Iceberg GPU acceleration is not currently packaged for Spark 3.4.x" | ||
| }, | ||
| { | ||
| "version": "3.4.4", | ||
| "supported": false, | ||
| "reason": "Iceberg GPU acceleration is not currently packaged for Spark 3.4.x" | ||
| }, | ||
| { | ||
| "version": "3.5.1", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "3.5.2", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "3.5.3", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "3.5.4", | ||
| "supported": false, | ||
| "reason": "The Iceberg 1.6.x integration module is not packaged for Spark 3.5.4 and later" | ||
| }, | ||
| { | ||
| "version": "3.5.5", | ||
| "supported": false, | ||
| "reason": "The Iceberg 1.6.x integration module is not packaged for Spark 3.5.4 and later" | ||
| }, | ||
| { | ||
| "version": "3.5.6", | ||
| "supported": false, | ||
| "reason": "The Iceberg 1.6.x integration module is not packaged for Spark 3.5.4 and later" | ||
| }, | ||
| { | ||
| "version": "3.5.7", | ||
| "supported": false, | ||
| "reason": "The Iceberg 1.6.x integration module is not packaged for Spark 3.5.4 and later" | ||
| }, | ||
| { | ||
| "version": "3.5.8", | ||
| "supported": false, | ||
| "reason": "The Iceberg 1.6.x integration module is not packaged for Spark 3.5.4 and later" | ||
| }, | ||
| { | ||
| "version": "3.5.9", | ||
| "supported": false, | ||
| "reason": "The Iceberg 1.6.x integration module is not packaged for Spark 3.5.4 and later" | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "version": "1.9.2", | ||
| "upstream_minimums": { | ||
| "3.4": "3.4.4", | ||
| "3.5": "3.5.5" | ||
| }, | ||
| "spark_versions": [ | ||
| { | ||
| "version": "3.4.4", | ||
| "supported": false, | ||
| "reason": "Iceberg GPU acceleration is not currently packaged for Spark 3.4.x" | ||
| }, | ||
| { | ||
| "version": "3.5.5", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "3.5.6", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "3.5.7", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "3.5.8", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "3.5.9", | ||
| "supported": true | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "version": "1.10.1", | ||
| "upstream_minimums": { | ||
| "3.4": "3.4.4", | ||
| "3.5": "3.5.6", | ||
| "4.0": "4.0.0" | ||
| }, | ||
| "spark_versions": [ | ||
| { | ||
| "version": "3.4.4", | ||
| "supported": false, | ||
| "reason": "Iceberg GPU acceleration is not currently packaged for Spark 3.4.x" | ||
| }, | ||
| { | ||
| "version": "3.5.6", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "3.5.7", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "3.5.8", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "3.5.9", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "4.0.0", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "4.0.1", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "4.0.2", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "4.0.3", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "4.0.4", | ||
| "supported": true | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "version": "1.11.0", | ||
| "upstream_minimums": { | ||
| "3.4": "3.4.4", | ||
| "3.5": "3.5.8", | ||
| "4.0": "4.0.2", | ||
| "4.1": "4.1.1" | ||
| }, | ||
| "spark_versions": [ | ||
| { | ||
| "version": "3.4.4", | ||
| "supported": false, | ||
| "reason": "Iceberg GPU acceleration is not currently packaged for Spark 3.4.x" | ||
| }, | ||
| { | ||
| "version": "3.5.8", | ||
| "supported": false, | ||
| "reason": "The Iceberg 1.11.x integration module is not currently packaged for Spark 3.5.x" | ||
| }, | ||
| { | ||
| "version": "3.5.9", | ||
| "supported": false, | ||
| "reason": "The Iceberg 1.11.x integration module is not currently packaged for Spark 3.5.x" | ||
| }, | ||
| { | ||
| "version": "4.0.2", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "4.0.3", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "4.0.4", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "4.1.1", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "4.1.2", | ||
| "supported": true | ||
| }, | ||
| { | ||
| "version": "4.1.3", | ||
| "supported": true | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supported Spark × Iceberg combinations can and should be derived from Maven release profiles and module POMs. This JSON is not the source of truth has already diverged:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a combination of upstream oss with our pom, and they are not diverged.
For example: Spark 3.5.0 => no Iceberg version, there is no 3.5.0 listed the json.