Run and report withResource nesting lint with Jython [reduced-it] - #15879
Open
gerashegalov wants to merge 8 commits into
Open
Run and report withResource nesting lint with Jython [reduced-it]#15879gerashegalov wants to merge 8 commits into
gerashegalov wants to merge 8 commits into
Conversation
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Contributor
Greptile SummaryThis PR ports the withResource nesting lint and tests to Jython 2.7-compatible Python while retaining Python 3 compatibility.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "Publish withResource nesting audit repor..." | Re-trigger Greptile |
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Collaborator
Author
|
build |
Collaborator
Author
|
Here is the direct link to the report. @wjxiz1992 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #11713.
Description
The repository-wide withResource nesting lint currently requires a host Python 3 executable and is repeated by both generated Scala root builds. This change ports the lint and its unit tests to code compatible with Jython 2.7.3 while retaining Python 3 compatibility.
Maven now launches the tests and repository scan through its existing managed Jython dependency. A dedicated root execution runs only from the canonical Scala 2.12 reactor; the generated Scala 2.13 POM keeps its Scala-specific checks but does not repeat this repository-wide scan.
A new pull-request check publishes every detected deep scope in the GitHub job summary and a JSON artifact. It annotates the first 50 source locations, GitHub Actions annotation limit used by the check, while the complete set remains available in both reports. Baselined scopes are visible existing debt and do not fail the check. New violations, stale baseline entries, invalid exemptions, or report-generation errors remain failures.
The depth-four policy, exemption behavior, CLI flags, diagnostics, exit codes, baseline schema, and all 59 existing fingerprints remain unchanged. Ordered JSON serialization and normalized source traversal keep generated baselines byte-for-byte identical across Jython and Python 3.
This PR contains no deprecation-policy or deprecation-audit changes.
Validation performed:
Performance testing is not required because this changes build-time lint tooling only and does not modify production runtime code.
Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance