Update dependencies for renamed cudf-spark-private artifacts - #15881
Merged
Conversation
Contributor
Greptile SummaryThe PR consistently migrates the private plugin dependency and build-information resource to the new
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
P[Root Maven property] --> S[SQL plugin dependency]
P --> A[Aggregator dependency]
S --> J[Packaged plugin JAR]
A --> J
W[Verification workflow] --> H[Snapshot checksum helper]
H --> C[Dependency cache key]
J --> R[Private build-info resource]
R --> B[Plugin initialization]
Reviews (4): Last reviewed commit: "Load renamed private build info resource" | Re-trigger Greptile |
NvTimLiu
force-pushed
the
private-artifacatId-rename
branch
from
September 3, 2026 04:47
1f79850 to
d471bd0
Compare
Collaborator
Author
|
build |
NvTimLiu
requested review from
GaryShen2008 and
sameerz
and
a lite review from Copilot
September 4, 2026 02:34
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to Maven coordinates and the corresponding CI checksum lookup, and repository-wide searches show no remaining references to the old private artifactId.
Pull request overview
Updates this repository’s build-time dependency coordinates to consume the renamed private plugin artifacts (rapids-4-spark-private_* → cudf-spark-private_*) across both Scala 2.12 and 2.13 builds, and keeps CI cache invalidation working by updating the snapshot checksum lookup script accordingly.
Changes:
- Switch SQL plugin and aggregator Maven dependencies to
cudf-spark-private_${scala.binary.version}for Scala 2.12 and 2.13. - Update the mvn-verify dependency SHA1 helper to query the renamed private snapshot artifact path.
File summaries
| File | Description |
|---|---|
| sql-plugin/pom.xml | Updates Scala 2.12 SQL plugin dependency artifactId for the private plugin. |
| scala2.13/sql-plugin/pom.xml | Updates Scala 2.13 SQL plugin dependency artifactId for the private plugin. |
| aggregator/pom.xml | Updates Scala 2.12 aggregator dependency artifactId for the private plugin. |
| scala2.13/aggregator/pom.xml | Updates Scala 2.13 aggregator dependency artifactId for the private plugin. |
| .github/workflows/mvn-verify-check/get-deps-sha1.sh | Updates CI cache-key dependency SHA1 lookup to follow the renamed private snapshot artifactId. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collaborator
Author
|
Build PASS: |
GaryShen2008
reviewed
Sep 4, 2026
Collaborator
Author
|
build |
GaryShen2008
previously approved these changes
Sep 4, 2026
Update the Scala 2.12 and 2.13 SQL plugin and aggregator dependencies to use the renamed cudf-spark-private artifact prefix. Point the Maven verification checksum helper at the renamed snapshot artifact so dependency cache invalidation continues to track private plugin updates. Signed-off-by: timl <timl@nvidia.com>
Align the Maven version property with the cudf-spark-private artifact coordinate introduced by the private artifact rename. Rename the root property and the SQL plugin and aggregator dependency references for Scala 2.12, then regenerate the corresponding Scala 2.13 POMs. Update both Maven verification workflow paths so snapshot cache keys and shim selection continue to read the private dependency version. Blossom and other external callers that override or evaluate spark-rapids-private.version must migrate to cudf-spark-private.version as part of the coordinated rollout. Signed-off-by: timl <timl@nvidia.com>
Signed-off-by: timl <timl@nvidia.com>
NvTimLiu
force-pushed
the
private-artifacatId-rename
branch
from
September 4, 2026 09:08
f291e6f to
9ae8dcd
Compare
Collaborator
Author
|
build |
Collaborator
Author
|
pre-merge Build PASS: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: part of #15882.
This change updates the Scala 2.12 and Scala 2.13 private-plugin Maven coordinates from
rapids-4-spark-private_*tocudf-spark-private_*, renames the corresponding Maven version property,updates CI dependency-cache lookup paths, and loads private build metadata from cudf-spark-private-version-info.properties.
The dependency contents and Spark execution paths are unchanged.
Performance testing is not required because this changes dependency coordinates and metadata resource naming only; no Spark execution or GPU processing path changes.
Checklists
Documentation
Testing
(Please provide the names of the existing tests in the PR description.)
Performance