Finalize Iceberg root and shim class placement [reduced-it] - #15944
Draft
gerashegalov wants to merge 11 commits into
Draft
Finalize Iceberg root and shim class placement [reduced-it]#15944gerashegalov wants to merge 11 commits into
gerashegalov wants to merge 11 commits into
Conversation
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
…independent-helpers Signed-off-by: Gera Shegalov <gshegalov@nvidia.com> # Conflicts: # dist/unshimmed-common-from-single-shim.txt
…independent-helpers Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
…independent-helpers Signed-off-by: Gera Shegalov <gshegalov@nvidia.com> # Conflicts: # dist/unshimmed-common-from-single-shim.txt
…independent-helpers Signed-off-by: Gera Shegalov <gshegalov@nvidia.com> # Conflicts: # dist/unshimmed-common-from-single-shim.txt
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
…independent-helpers Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #15821.
Stacked on #15841.
Description
This PR completes the Iceberg class-placement milestone:
iceberg-commonspark-sharedunshimmed-common-from-single-shim.txtAfter this change, assembled multi-shim distribution JARs contain no Iceberg classes under
spark-shared. The shared, root-safe Iceberg helpers are at the JAR root, while Spark- and Iceberg-version-specific implementations remain undersparkXYZ.There are no user-facing configuration or API changes.
This PR remains a draft while stacked:
mainis up-merged and CI is rerunValidation:
334,344,353,359353,359,404,413,420spark-shared, and the remaining classes under Spark-specific directoriesGpuBaseReadercame from its newest applicable classifier, Spark 3.5.3extraClassPath: 6 passedChecklists
Documentation
Testing
(
IcebergDeletionVectorSuiteand the Iceberg read, append, and no-op-write integration smoke tests)Performance
Performance testing is not required because this changes build-time source selection and JAR placement without modifying runtime execution logic.
This change and its validation were prepared with AI assistance and reviewed by a human before publication.