Fix root-safe provider test runtime stub [reduced-it] - #15985
Merged
res-life merged 1 commit intoSep 14, 2026
Merged
Conversation
Signed-off-by: Hongbin Ma <mahongbin@apache.org>
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
8 tasks
Contributor
|
Collaborator
|
I was including it in #15958. But a dedicated fix is faster. |
Collaborator
|
build |
8 tasks
firestarman
approved these changes
Sep 14, 2026
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15944 and #15957.
Description
After both Iceberg packaging changes reached
main,package-parallel-worlds.pybegan readingsystem_runtime_pathfrom the loadediceberg_runtime.pymodule.RootSafeProviderSelectionTestcreates a minimal fake version of that module, but the fixture still defined onlycoordinates. As a result, the standard-assembler subtest failed withKeyError: 'system_runtime_path'before Maven compilation, causing install and verify matrix jobs on subsequent pull requests to fail or be canceled by fail-fast.This change adds the missing
system_runtime_pathfunction to the fake module. It returnsNone, matching the test fixture's existing behavior when no explicit system Iceberg runtime is configured. Production code is unchanged.Validation on current
main(b23ab02e986767dfd26fde2e221d58658d9a2179):The failure was also reproduced before the fixture change with the same
KeyErrorreported by the Maven matrix in #15982.This change was prepared with AI assistance and reviewed by the author.
Checklists
Documentation
Testing
Performance