Centralize CPM dependency source metadata #24148
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # ============================================================================= | ||
| # cmake-format: off | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # cmake-format: on | ||
| # ============================================================================= | ||
| cmake_minimum_required(VERSION 4.0 FATAL_ERROR) | ||
|
|
||
| project(cpm_project_package_info_test LANGUAGES NONE) | ||
|
Member
There was a problem hiding this comment. What exactly is this file testing? |
||
|
|
||
| set(CUDF_REPOSITORY_DIR | ||
| "" | ||
| CACHE PATH "Path to the cuDF repository root" | ||
| ) | ||
| if(NOT CUDF_REPOSITORY_DIR) | ||
| cmake_path(SET CUDF_REPOSITORY_DIR NORMALIZE "${CMAKE_CURRENT_LIST_DIR}/../../../..") | ||
| endif() | ||
|
|
||
| set(EXPECTED_DLPACK_VERSION | ||
| "0.8" | ||
| CACHE STRING "Expected resolved DLPack version" | ||
| ) | ||
| set(EXPECTED_FLATBUFFERS_VERSION | ||
| "24.3.25" | ||
| CACHE STRING "Expected resolved FlatBuffers version" | ||
| ) | ||
|
|
||
| include("${CUDF_REPOSITORY_DIR}/cmake/rapids_config.cmake") | ||
| set(CUDF_VERSION_MAJOR 98) | ||
| set(CUDF_VERSION_MINOR 76) | ||
| include("${rapids-cmake-dir}/cpm/init.cmake") | ||
| rapids_cpm_init() | ||
| # cmake-lint: disable=C0111 | ||
| function(assert_project_package_version package_name expected_version) | ||
| include("${CUDF_REPOSITORY_DIR}/cpp/cmake/thirdparty/rapids_cpm_project_package_info.cmake") | ||
| cudf_cpm_project_package_info(${package_name} VERSION_VAR resolved_version) | ||
| if(NOT resolved_version STREQUAL expected_version) | ||
| message( | ||
| FATAL_ERROR "Expected ${package_name} version ${expected_version}, got ${resolved_version}" | ||
| ) | ||
| endif() | ||
| endfunction() | ||
|
|
||
| # Resolve packages from separate function scopes to verify that the catalog path remains available | ||
| # after the helper's global include guard suppresses subsequent includes. | ||
| assert_project_package_version(dlpack "${EXPECTED_DLPACK_VERSION}") | ||
| assert_project_package_version(flatbuffers "${EXPECTED_FLATBUFFERS_VERSION}") | ||
| assert_project_package_version(kvikio "${CUDF_VERSION_MAJOR}.${CUDF_VERSION_MINOR}") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "packages": { | ||
| "dlpack": { | ||
| "version": "9.9.9", | ||
| "git_url": "https://github.com/dmlc/dlpack.git", | ||
| "git_tag": "365b823cedb281cd0240ca601aba9b78771f91a3", | ||
| "git_shallow": true | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| { | ||
| "packages": { | ||
| "Arrow": { | ||
| "version": "21.0.0", | ||
| "git_url": "https://github.com/apache/arrow.git", | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| "git_tag": "ee4d09ebef61c663c1efbfa4c18e518a03b798be", | ||
| "git_tag_alias": "apache-arrow-21.0.0", | ||
| "git_shallow": true, | ||
| "source_subdir": "cpp" | ||
| }, | ||
| "cudf": { | ||
| "version": "${CUDF_VERSION_MAJOR}.${CUDF_VERSION_MINOR}.00", | ||
| "git_url": "https://github.com/NVIDIA/cudf.git", | ||
| "git_tag": "742e4fd85f3ae440ca78a3a722ed1603d44a841f", | ||
| "git_tag_alias": "${RAPIDS_BRANCH}", | ||
| "git_shallow": true, | ||
| "source_subdir": "cpp" | ||
| }, | ||
| "dlpack": { | ||
| "version": "0.8", | ||
| "git_url": "https://github.com/dmlc/dlpack.git", | ||
| "git_tag": "365b823cedb281cd0240ca601aba9b78771f91a3", | ||
| "git_tag_alias": "v0.8", | ||
| "git_shallow": true | ||
| }, | ||
| "flatbuffers": { | ||
| "version": "24.3.25", | ||
| "git_url": "https://github.com/google/flatbuffers.git", | ||
| "git_tag": "595bf0007ab1929570c7671f091313c8fc20644e", | ||
| "git_tag_alias": "v24.3.25", | ||
| "git_shallow": true | ||
| }, | ||
| "kvikio": { | ||
| "version": "${CUDF_VERSION_MAJOR}.${CUDF_VERSION_MINOR}", | ||
| "git_url": "https://github.com/rapidsai/kvikio.git", | ||
|
msarahan marked this conversation as resolved.
|
||
| "git_tag": "e4cb3cab779fcdc3341e0ef446d28a31f2a96d8a", | ||
| "git_tag_alias": "${RAPIDS_BRANCH}", | ||
| "git_shallow": true, | ||
| "source_subdir": "cpp" | ||
| }, | ||
| "nanoarrow": { | ||
| "version": "0.8.0", | ||
| "git_url": "https://github.com/apache/arrow-nanoarrow.git", | ||
| "git_tag": "a579fbf5d192e85b6249935e117de7d02a6dc4e9", | ||
| "git_tag_alias": "apache-arrow-nanoarrow-0.8.0", | ||
| "git_shallow": true | ||
| }, | ||
| "roaring": { | ||
| "version": "4.4.2", | ||
| "git_url": "https://github.com/RoaringBitmap/CRoaring.git", | ||
| "git_tag": "24835ad92064137eda061abfc019dd2b4ebc87a9", | ||
| "git_tag_alias": "v4.4.2", | ||
| "git_shallow": true | ||
| }, | ||
| "zstd": { | ||
| "version": "1.5.7", | ||
| "git_url": "https://github.com/facebook/zstd.git", | ||
| "git_tag": "f8745da6ff1ad1e7bab384bd1f9d742439278e99", | ||
| "git_tag_alias": "v1.5.7", | ||
| "git_shallow": false, | ||
| "source_subdir": "build/cmake" | ||
| }, | ||
| "xxhash": { | ||
| "version": "0.8.3", | ||
| "git_url": "https://github.com/Cyan4973/xxHash.git", | ||
| "git_tag": "e626a72bc2321cd320e953a0ccf1584cad60f363", | ||
| "git_shallow": true | ||
| }, | ||
| "rtcx": { | ||
| "version": "0.1", | ||
| "git_url": "https://github.com/rapidsai/librtcx.git", | ||
| "git_tag": "a9f63f8cdd4b0b41a2d88a9f705576a61b4222ec", | ||
| "git_shallow": false | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # ============================================================================= | ||
| # cmake-format: off | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # cmake-format: on | ||
| # ============================================================================= | ||
|
|
||
| include_guard(GLOBAL) | ||
|
|
||
| set_property( | ||
| GLOBAL PROPERTY cudf_cpm_project_versions_file | ||
| "${CMAKE_CURRENT_LIST_DIR}/rapids-cpm-versions.json" | ||
| ) | ||
|
|
||
| # Resolve project-owned defaults through rapids-cmake so a parent build can replace a package source | ||
| # with RAPIDS_CMAKE_CPM_OVERRIDE_VERSION_FILE. | ||
| macro(cudf_cpm_project_package_info) | ||
| get_property(_cudf_cpm_project_versions_file GLOBAL PROPERTY cudf_cpm_project_versions_file) | ||
| include("${rapids-cmake-dir}/cpm/package_override.cmake") | ||
| rapids_cpm_package_override("${_cudf_cpm_project_versions_file}") | ||
| include("${rapids-cmake-dir}/cpm/detail/package_info.cmake") | ||
| rapids_cpm_package_info(${ARGV}) | ||
| endmacro() |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should consider instead making this its own local pre-commit hook, and have the test run in some other part of CI. WDYT?