Replace remaining rmm::cuda_stream_view with cuda::stream_ref - #24152
davidwendt wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe Parquet dictionary remapping function now accepts ChangesParquet reader update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to This localized type migration does not change remapping behavior or introduce a merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bdice
left a comment
There was a problem hiding this comment.
Please retarget to 26.10 if the other PR landed there.
|
The code is correct in 26.10 so looks like we are blocked by the forward-merger conflict somewhere. |
|
The change is in blocked in here #24133 |
Description
One
rmm::cuda_stream_viewleaked through via crossed merge with #23929 work.Checklist