You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Tooltip is clipped inside hidden search result rows
src/view/search-results.inc.twig:37
These t-top tooltips are rendered inside list items that truncateSearchResults() changes to .search-result-hidden. That class has overflow: hidden (resource/css/skosmos.css:1631-1636), so on every truncated row the tooltip is translated above the item and clipped, making the newly added hover explanation invisible. The clipping needs to be applied to the value span rather than the whole row (or the tooltip must render outside the clipped container).
Preserve spacing after notation icon
src/view/search-results.inc.twig:15
The following {%~ if concept.notation %} strips the whitespace after this icon, so removing the explicit renders the arrow directly adjacent to the notation or concept link. Add an explicit margin to preserve separation regardless of Twig whitespace trimming.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
There are some rough spots in the current Skosmos layout. This PR proposes some fixes.
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
Keyboard navigation support for tooltips is not implemented in this PR. We have issue #1967 open regarding that.
Checklist
.sr-onlyclass, color contrast)