Skip to content

EKIRJASTO-987 Remove ios-tenprintcover dependency - #193

Open
natlibfi-ptalosel wants to merge 18 commits into
mainfrom
ekirjasto-987-remove-tenprintcover-submodule
Open

natlibfi-ptalosel wants to merge 18 commits into
mainfrom
ekirjasto-987-remove-tenprintcover-submodule

Conversation

@natlibfi-ptalosel

@natlibfi-ptalosel natlibfi-ptalosel commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • This pull request removes the TenPrintCover dependency, a book cover generating tool
    • the dependency was a Palace fork of NYPL's 10 PRINT "BOOK COVER"
    • the ios-tenprintcover submodule, project target and related metadata were removed
  • The book cover generator was not used in practice
    • book suppliers provide cover images, so the submodule added maintenance overhead
  • When a book has no available cover image, the app shows a grey book image that says "NO COVER ART"
    • the generateBookCoverImage function was replaced by new function getPlaceholderBookCoverImage
  • EKIRJASTO-987

Review and testing instructions

  • Most important files to review:
    • TPPBookCoverRegistry.swift
      • minor refactoring and commenting
  • Test steps
    • build the app
      • check that dependency is not used anymore
    • run the app
      • first prepare a book without cover if possible
      • then check that the placeholder image is used instead of the missing cover on all book views
      • finally check that all books that have valid covers still display them normally
  • Automated tests

Checklist for the developer

  • Project documentation is up to date: project structure documentation updates
  • All new and existing tests pass
  • At least two reviewers added: E-kirjasto maintainers + one additional reviewer
  • AI was used during the process: help with file refactoring

@natlibfi-ptalosel natlibfi-ptalosel self-assigned this Oct 30, 2026
@natlibfi-ptalosel natlibfi-ptalosel changed the title EKIRJASTO-987 DRAFT EKIRJASTO-987 Remove ios-tenprintcover dependency and use placeholder image for missing covers Oct 30, 2026
@natlibfi-ptalosel natlibfi-ptalosel added dependencies Pull requests that update a dependency file maintenance Work to reduce technical debt, refactors, and general maintenance tasks. labels Oct 30, 2026
@natlibfi-ptalosel
natlibfi-ptalosel marked this pull request as ready for review October 30, 2026 17:45
@natlibfi-ptalosel
natlibfi-ptalosel requested a review from a team as a code owner October 30, 2026 17:45
@natlibfi-ptalosel natlibfi-ptalosel changed the title EKIRJASTO-987 Remove ios-tenprintcover dependency and use placeholder image for missing covers EKIRJASTO-987 Remove ios-tenprintcover dependency Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file maintenance Work to reduce technical debt, refactors, and general maintenance tasks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant