Skip to content
This repository was archived by the owner on May 27, 2026. It is now read-only.

fix: all test suites - #148

Merged
simonhamp merged 21 commits into
NativePHP:mainfrom
SRWieZ:fix-test-suite
Dec 26, 2024
Merged

fix: all test suites#148
simonhamp merged 21 commits into
NativePHP:mainfrom
SRWieZ:fix-test-suite

Conversation

@SRWieZ

@SRWieZ SRWieZ commented Dec 22, 2024

Copy link
Copy Markdown
Member

Back ports of my finding in #147

Funny thing, I started that other PR to just fix the test suite. Then my curiosity led me on an adventure in the JavaScript ecosystem and its quirks. After that, I was so deep into it that I couldn't stop.

Summary of changes:

  • [JS] Created a base mock for electron in jest
  • [JS] Updated tests that are mocking electron to extend the base one
  • [JS] Fixed jest.config.ts regex
  • [JS] Fixes somes unused imports ans dependencies
  • [PHP] tests against L11 and PHP 8.3
  • [PHP] Fixed test by requiring php-bin^5.0.1 instead of php-bin^5.0.0 with a weird zip.
  • [PHP] Fixed phpstan test suite along side all the errors it did find
  • [PHP] Added composer qa

@SRWieZ SRWieZ changed the title fix: test suite fix: all test suites Dec 22, 2024
@SRWieZ

SRWieZ commented Dec 22, 2024

Copy link
Copy Markdown
Member Author

ALL green! 🎉 ✅

Ready to be reviewed.

@simonhamp simonhamp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I just have one question:

Comment thread src/Updater/UpdaterManager.php
@simonhamp
simonhamp merged commit 8e4f571 into NativePHP:main Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants