Skip to content

fix: Android images default to Fit when no object-* class is set #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SRWieZ wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix: Android images default to Fit when no object-* class is set #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion resources/android/ImageRenderer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ object ImageRenderer {
fun Render(node: NativeUINode, modifier: Modifier) {
val p = node.props
val src = p.getString("src")
val fit = p.getInt("fit")
// No `fit` prop means no `object-*` class. Default to Fit (1) so
// an unclassed image scales into its frame like iOS does, instead
// of ContentScale.None painting the bitmap at intrinsic size and
// center-cropping it to the frame.
val fit = p.getInt("fit", 1)
val alt = p.getString("alt")
val tintArgb = p.getColor("tint_color", 0)
val radius = node.style?.borderRadius ?: 0f
Expand Down
Loading