fix: only attach iOS pull-to-refresh when the list declares on-refresh - #71
Open
SRWieZ wants to merge 1 commit into
Open
fix: only attach iOS pull-to-refresh when the list declares on-refresh#71SRWieZ wants to merge 1 commit into
SRWieZ wants to merge 1 commit into
Conversation
.refreshable was applied unconditionally, so every native:list — static settings screens and forms included — offered a pull-down spinner that did nothing. Gate the modifier on the on_refresh callback id, matching the Android renderer, which already wraps its PullToRefreshBox in the same check.
SRWieZ
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
Every
native:liston iOS offers pull-to-refresh — including static settings screens and forms. Pull down and a spinner appears, spins, and does nothing.Why
The renderer applies
.refreshableunconditionally; theon_refreshcheck lives inside the closure:That guards the callback, but SwiftUI installs the refresh control (spinner included) the moment
.refreshableis attached — whether or not the closure does anything. The Android renderer already gates its wholePullToRefreshBoxononRefreshCb != 0, so the two platforms disagree.The fix
Move the check outside: a conditional modifier attaches
.refreshableonly when the list declares anon-refreshhandler. Lists without one scroll plainly, matching Android and the dedicatednative:refreshableelement's opt-in contract. Behavior with a handler is unchanged.