fix: Android bare text input ignores keyboard="number" (and every keyboard type) - #74
Open
SRWieZ wants to merge 1 commit into
Open
fix: Android bare text input ignores keyboard="number" (and every keyboard type)#74SRWieZ wants to merge 1 commit into
SRWieZ wants to merge 1 commit into
Conversation
BareTextInputRenderer never forwarded keyboardOptionsFor(props) to its BasicTextField, so keyboard="number" (and the capitalization derived from the keyboard type) were silently ignored on bare inputs — the plain text keyboard always came up. Filled and Outlined already pass it; this brings Bare in line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong
keyboard="number"on<native:bare-text-input>shows the full text keyboard on Android. The filled and outlined renderers passkeyboardOptionsto their text field; the bare renderer never did — so the keyboard type (and the capitalization derived from it, and the IME action face) were silently dropped.Minimum repro:
What this does
One line — pass
keyboardOptionsFor(props)to the bare input'sBasicTextField, same as the other two variants. No iOS or PHP changes.Before / after (Android emulator, API 36, same Blade)