Repository navigation
fix(brand): let the app icon span its square edge to edge - #1110
Merged
Merged
Conversation
The application icon looked smaller than its neighbours in the Windows taskbar: the square source SVG kept an empty margin of about 4 % on each side, so the 24 px icon drew the CN in 22 x 12 px. The background is transparent, so the margin only shrank the mark. images/CodeNomad-Icon.svg is now cropped to a 510.4-unit square centred on the mark, which touches the left and right edges; its height still fills about half the square because the CN is twice as wide as it is tall. The 1024 px master, the in-app copy, the Electron and Tauri .ico/.icns/.png icons and the Linux sizes are regenerated from it: the 24 px Windows icon now draws the CN in 24 x 14 px, the 32 px one in 32 x 18 px. The in-app logos use the same PNG, so their heights shrink by the same ratio to keep the sizes already approved on screen: 5.55rem beside a text-3xl title, 4.44rem in the narrow session column and 7.4rem on the loading screen. dev-docs/UI_CONVENTIONS.md records the new values. The regenerated icon.png loses no opaque pixel of the master (pixel comparison of the two 1024 px images), and the mark spans columns 0 to 1023. The UI typecheck passes.
Contributor
Author
|
zero findings — no evidenced P0–P3 problems in
Worktree remains unchanged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The app icon looked smaller than its neighbours in the Windows taskbar: the square source SVG kept an empty ~4 % margin on each side, so the 24 px icon drew the CN in 22 x 12 px on a transparent background.
images/CodeNomad-Icon.svgis cropped to a square centred on the mark, touching the left and right edges (height stays about half: the CN is twice as wide as tall)..ico/.icns/.pngand Linux sizes regenerated: 24 px now 24 x 14 px, 32 px now 32 x 18 px.dev-docs/UI_CONVENTIONS.mdupdated.Validation
icon.pngloses no opaque pixel of the master; the mark spans columns 0-1023..icoentries before and after.npm run typecheck --workspace @codenomad/ui.