track mod enable/disable/remove and install kind in mixpanel#23649
Open
IDCs wants to merge 3 commits into
Open
track mod enable/disable/remove and install kind in mixpanel#23649IDCs wants to merge 3 commits into
IDCs wants to merge 3 commits into
Conversation
- Add mods_state_changed and mods_removed events, gated to Nexus mods like the other per-mod events, carrying a ModChangeReason (user_manual, variant_replace, version_update, profile_replace, collection_update, collection_uninstall, stop_managing_game, health_check) threaded through IRemoveModOptions and IEnableOptions from the remove/enable call sites. - Add install_kind (fresh / version_update / reinstall / variant / profile_replace) to the mods_installation_* events, classified in InstallManager and carried to the terminal events via InstallContext. - Report mods_state_changed.duration_ms as time spent in the prior state in both directions; add a durable disabledTime to profile mod-state alongside enabledTime. - Base mods_download_completed duration_ms on the durable startTime. - Move ReplaceChoice/IReplaceChoice to their own types file. - Add test harness (makeModChangeHarness/modChangeTest, makeProfile) and coverage for classifyInstallKind and the mod-change analytics. closes LAZ-673
It's timing out when the full suite is running and the emit-helper tests already cover this path.
Aragas
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes LAZ-673