Skip to content

libe57format: Disable LTO to fix linker error in downstream builds that use .a file#410786

Merged
nh2 merged 1 commit into
NixOS:masterfrom
nh2:libe57format-disable-lto
Jun 10, 2025
Merged

libe57format: Disable LTO to fix linker error in downstream builds that use .a file#410786
nh2 merged 1 commit into
NixOS:masterfrom
nh2:libe57format-disable-lto

Conversation

@nh2

@nh2 nh2 commented May 25, 2025

Copy link
Copy Markdown
Contributor

See asmaloney/libE57Format#313 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nh2 nh2 self-assigned this May 25, 2025
@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels May 25, 2025
@nix-owners nix-owners Bot requested a review from chpatrick May 25, 2025 12:54
@nh2 nh2 merged commit afa5445 into NixOS:master Jun 10, 2025
3 of 4 checks passed
@nixpkgs-ci

nixpkgs-ci Bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants