You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Upstream does not ship py.typed, so add it manually in postInstall to
mark the package as typed. This enables type checking for downstream
users using mypy or other type checkers.
@GaetanLepage Can you review this method for adding the py.typed into the package? It's working locally for my LSP. I've also created the upstream 1Password/onepassword-sdk-python#226 to include it natively.
I think that could be acceptable, but it would be better to submit a PR upstream adding the file, and then applying the commit using postPatch.
Agreed, I just have no timeline on when/if they're going to review/merge that PR. Do we have a convention for internal patch release until new beta/version is available upstream with the merged changes?
I think that could be acceptable, but it would be better to submit a PR upstream adding the file, and then applying the commit using postPatch.
Agreed, I just have no timeline on when/if they're going to review/merge that PR. Do we have a convention for internal patch release until new beta/version is available upstream with the merged changes?
Yes, this is fairly common. You can use fetchpatch while the fix has not made its way to the release we're currently packaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
mahyarmirrashed
force-pushed
the
mahyarmirrashed/add-py-typed-to-onepassword-sdk
branch
from
Upstream does not ship py.typed, so add it manually in postInstall to
mark the package as typed. This enables type checking for downstream
users using mypy or other type checkers.
Fixes: 1Password/onepassword-sdk-python#220
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.