Skip to content

python3Packages.update-dotdee: modernize and migrate to pyproject and add changelog - #528097

Merged
Sigmanificient merged 2 commits into
NixOS:masterfrom
Ambossmann:pyproject-migration/python3Packages.update-dotdee
Jun 21, 2026
Merged

python3Packages.update-dotdee: modernize and migrate to pyproject and add changelog#528097
Sigmanificient merged 2 commits into
NixOS:masterfrom
Ambossmann:pyproject-migration/python3Packages.update-dotdee

Conversation

@Ambossmann

@Ambossmann Ambossmann commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Things done

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 6.topic: python Python is a high-level, general-purpose programming language. labels Jun 4, 2026
@Sigmanificient Sigmanificient mentioned this pull request Jun 4, 2026
Open
Sigmanificient
Sigmanificient approved these changes Jun 4, 2026
View reviewed changes

@Sigmanificient Sigmanificient left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff lgtm, work with python3.12, but a deps is blcoking for 3.13+
executor-23.2 not supported for interpreter python3.13

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Jun 4, 2026
@Ambossmann

Ambossmann commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

diff lgtm, work with python3.12, but a deps is blcoking for 3.13+ executor-23.2 not supported for interpreter python3.13

That is fixed with #528079

@Sigmanificient

Sigmanificient commented Jun 19, 2026

Copy link
Copy Markdown
Member

Error updating the branch: GraphQL: user doesn't have permission to update head repository 🤔

@Ambossmann
Ambossmann force-pushed the pyproject-migration/python3Packages.update-dotdee branch from de2b971 to 30d128c Compare June 20, 2026 09:48
@Ambossmann
Ambossmann force-pushed the pyproject-migration/python3Packages.update-dotdee branch from 30d128c to fdb12c0 Compare June 20, 2026 09:51
@Ambossmann

Ambossmann commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Error updating the branch: GraphQL: user doesn't have permission to update head repository 🤔

I rebased it onto master in case that was what you were trying to do.

@nixpkgs-ci
nixpkgs-ci Bot requested a review from eyJhb June 20, 2026 09:57
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 20, 2026
@eyJhb

eyJhb commented Jun 20, 2026

Copy link
Copy Markdown
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 528097
Commit: fdb12c01c6497ed9a81c351b6641f256ba6a7399

x86_64-linux

✅ 3 packages built:
  • update-dotdee (python313Packages.update-dotdee)
  • python314Packages.update-dotdee
  • rotate-backups

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 20, 2026
@Sigmanificient
Sigmanificient added this pull request to the merge queue Jun 21, 2026
Merged via the queue into NixOS:master with commit b97543f Jun 21, 2026
31 checks passed
@Ambossmann
Ambossmann deleted the pyproject-migration/python3Packages.update-dotdee branch June 23, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes
+1 more reviewer
@eyJhb eyJhb eyJhb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ambossmann @Sigmanificient @eyJhb