libultrahdr: fix tests on big-endian - #533532
Closed
zwang20 wants to merge 1 commit into
Closed
Conversation
Contributor
|
The other PR is the only reason that this is even an issue, because there is not a single BE target in the allowed platforms before the CMake patch you want to pull in, and building on BE regardless by ignoring |
![nixpkgs-branch-check[bot]](https://avatars.githubusercontent.com/u/487568?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
zwang20
force-pushed
the
fix-libultrahdr-2
branch
from
June 20, 2026 08:23
cb60f8c to
3e9bff5
Compare
nixpkgs-branch-check
Bot
dismissed
their stale review
June 20, 2026 08:24
Review dismissed automatically
Contributor
Author
|
I think I will defer this decision to the package maintainer, @yzx9 |
Contributor
|
Thanks for the ping. I would prefer to merge them to make testing easier for the reviewer. |
Contributor
|
7vvppp2h362pis9jxbaf26vajaq6c5dq-libultrahdr-1.4.0.drv.log ¯\_(ツ)_/¯ |
nixpkgs-ci
Bot
added
10.rebuild-linux: 501+
Contributor
Author
|
Closing in favor of #533168 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes tests on big-endian by incorporating the upstream commit in google/libultrahdr#396, as requested by @OPNA2608 on #533168
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.