libultrahdr: fix build on i686-linux - #533983
Closed
geri1701 wants to merge 1 commit into
Closed
Conversation
Link with libatomic on i686-linux to resolve GCC atomic builtin references. Also skip the three i686-only rounding-sensitive tests that fail due to small floating-point differences. Closes NixOS#532626 Assisted-by: pi coding agent / Mika (OpenAI GPT-5.5)
Contributor
Contributor
|
Before #533168, all x86 builds were reset to i386, which requires |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link with libatomic on i686-linux to resolve the missing GCC atomic builtin reference.
The i686 build then reaches the test suite. Three i686-only rounding-sensitive
GainMapMathtests are filtered due to small floating-point differences.Closes #532626
Assisted-by: pi coding agent / Mika (OpenAI GPT-5.5)
Things done
passthru.tests.nixpkgs-reviewon this PR. See [nixpkgs-review usage]../result/bin/.READMEs.