Skip to content

libultrahdr: fix build on i686-linux - #533983

Closed
geri1701 wants to merge 1 commit into
NixOS:masterfrom
geri1701:libultrahdr-fix-i686
Closed

libultrahdr: fix build on i686-linux#533983
geri1701 wants to merge 1 commit into
NixOS:masterfrom
geri1701:libultrahdr-fix-i686

Conversation

@geri1701

Copy link
Copy Markdown
Member

Link with libatomic on i686-linux to resolve the missing GCC atomic builtin reference.

The i686 build then reaches the test suite. Three i686-only rounding-sensitive
GainMapMath tests are filtered due to small floating-point differences.

Closes #532626

Assisted-by: pi coding agent / Mika (OpenAI GPT-5.5)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
    • [NixOS tests] in [nixos/tests].
    • [Package tests] at passthru.tests.
    • Tests in [lib/tests] or [pkgs/test] for functions and "core" functionality.
  • Ran nixpkgs-review on this PR. See [nixpkgs-review usage].
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits [CONTRIBUTING.md], [pkgs/README.md], [maintainers/README.md] and other
    READMEs.
  • Follows the [automation/AI policy].

Link with libatomic on i686-linux to resolve GCC atomic builtin references. Also skip the three i686-only rounding-sensitive tests that fail due to small floating-point differences.

Closes NixOS#532626

Assisted-by: pi coding agent / Mika (OpenAI GPT-5.5)
@nixpkgs-ci
nixpkgs-ci Bot requested a review from yzx9 June 21, 2026 18:29
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jun 21, 2026
@yzx9

yzx9 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Hi, is #533168 not working as expected?

cc @zwang20

@zwang20

zwang20 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Before #533168, all x86 builds were reset to i386, which requires -latomic to compile.

@geri1701

Copy link
Copy Markdown
Member Author

Thanks for the pointers. I missed #533168 in the issue timeline.

Since #533168 has already been merged into staging and is the more complete fix for
#532626, this PR is superseded. I’m closing it to avoid keeping a competing master-only
workaround around.

@geri1701 geri1701 closed this Jun 22, 2026
@geri1701
geri1701 deleted the libultrahdr-fix-i686 branch July 15, 2026 15:53
@Sigmanificient Sigmanificient added the llm-assisted Contributions that include code generation with LLMs label Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. llm-assisted Contributions that include code generation with LLMs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: i686-linux.libultrahdr

4 participants