Repository navigation
fix: require Charge.period to be the first day of the month - #66
Merged
Merged
Conversation
period identifies WHICH MONTH a bill covers, not a specific day within it. A charge dated 2026-08-29 and one dated 2026-08-01 would look like two different billing periods to every range query and grouping, silently fragmenting the data. Rejects rather than silently normalizing to day 1 -- an API that quietly changes what a client submitted hides mistakes instead of surfacing them, the same reasoning behind returning 409 on re-cancelling rather than succeeding silently. Duplicated on ChargeUpdate rather than inherited, since ChargeUpdate is standalone -- without the second copy, a PATCH could reintroduce exactly the mid-month period that creation rejects, through the only endpoint allowed to change period.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
period identifies WHICH MONTH a bill covers, not a specific day within it. A charge dated 2026-08-29 and one dated 2026-08-01 would look like two different billing periods to every range query and grouping, silently fragmenting the data.
Rejects rather than silently normalizing to day 1 -- an API that quietly changes what a client submitted hides mistakes instead of surfacing them, the same reasoning behind returning 409 on re-cancelling rather than succeeding silently.
Duplicated on ChargeUpdate rather than inherited, since ChargeUpdate is standalone -- without the second copy, a PATCH could reintroduce exactly the mid-month period that creation rejects, through the only endpoint allowed to change period.