Repository navigation
feat: add Payment schemas - #71
Merged
Merged
Conversation
PaymentBase/Create/Cancel/Response following Charge's pattern. No PaymentUpdate class by design -- with the amount forced to equal the charge amount and method/reference being incidental, there is nothing meaningful to edit. Void and re-record instead. The schema can only validate amount > 0. The real rule, that amount must exactly equal the charge's amount, needs the Charge row and so lives in PaymentService. method and reference are independently optional -- a reference without a method is deliberately allowed, since a staff member might record an M-Pesa code without selecting the method, and rejecting that would discard useful information over a formality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PaymentBase/Create/Cancel/Response following Charge's pattern. No PaymentUpdate class by design -- with the amount forced to equal the charge amount and method/reference being incidental, there is nothing meaningful to edit. Void and re-record instead.
The schema can only validate amount > 0. The real rule, that amount must exactly equal the charge's amount, needs the Charge row and so lives in PaymentService.
method and reference are independently optional -- a reference without a method is deliberately allowed, since a staff member might record an M-Pesa code without selecting the method, and rejecting that would discard useful information over a formality.