Skip to content

[FIX] checklog-odoo.cfg: ignore Killing chrome descendants-or-self warning#218

Open
dnplkndll wants to merge 1 commit into
OCA:19.0from
ledoent:19.0-fix-checklog-chrome-zombie
Open

[FIX] checklog-odoo.cfg: ignore Killing chrome descendants-or-self warning#218
dnplkndll wants to merge 1 commit into
OCA:19.0from
ledoent:19.0-fix-checklog-chrome-zombie

Conversation

@dnplkndll
Copy link
Copy Markdown
Contributor

@dnplkndll dnplkndll commented May 16, 2026

Summary

Add an ignore pattern to checklog-odoo.cfg so the well-known chrome-zombie WARNING from Odoo's HttpCase tour cleanup does not promote passing test runs to CI failures.

The pattern is verbatim the one already in use across the OCA org:

Repo Commit Author Date
OCA/web c7fbf2d Stefan Rijnhart 2026-04-13
OCA/server-ux ca7dd94 Stefan Rijnhart 2026-04-13
OCA/social b672f28 Luis Rodriguez 2026-04-13
OCA/website dce9ae7 Enric Tobella 2026-04-15

Plus ~16 other OCA repos with the same regex in their checklog-odoo.cfg (helpdesk, pos, dms, mail, reporting-engine, l10n-brazil, e-commerce, connector-telephony, account-analytic, contract, edi-framework, oca-custom, stock-weighing, route-planning, rma, …).

Why this matters for OCA/calendar

The chrome-zombie WARNING (introduced in odoo/odoo@d22e0b4e) is emitted by Odoo's HttpCase test framework when headless-chrome renderer subprocesses don't exit cleanly after a tour test. The test outcomes themselves are reported on a separate line.

resource_booking (currently on 18.0, in the process of being migrated to 19.0 in #217) has multiple tour tests (test_portal_no_bookings, test_portal_list_with_bookings, test_portal_scheduling_conflict) that hit this every run. Without this ignore pattern, the CI failure log looks like:

2026-05-16 09:00:07,221 306 WARNING odoo odoo.addons.resource_booking.tests.test_portal.PortalCase.test_portal_list_with_bookings: Killing chrome descendants-or-self of 323: 5 remaining
- chrome (zombie)
- chrome (zombie)
- chrome (zombie)
- chrome (zombie)
- chrome (zombie)
...
2026-05-16 ... INFO odoo odoo.tests.result: 0 failed, 0 error(s) of 49 tests when loading database 'odoo'
...
errors that caused failure (2):
... WARNING ... Killing chrome descendants-or-self of 323: 5 remaining
... WARNING ... Killing chrome descendants-or-self of 462: 5 remaining
Error: Errors detected in log.

All 49 tests pass. The only "errors that caused failure" are the two chrome WARNINGs. With this PR's ignore pattern, those WARNINGs land in the "errors that did not cause failure" bucket (as they do in OCA/web, OCA/server-ux, OCA/social et al.) and CI goes green.

Verification

Cherry-picked the same one-line change onto #217's branch and re-ran CI: all 7 checks pass (test with Odoo, test with OCB, pre-commit, codecov/patch, codecov/project, runboat/build, Detect unreleased dependencies). Plan to drop the equivalent commit from #217 once this PR merges so the MIG stays scope-clean.

Test plan

Convention used

Same regex format as OCA/web's checklog-odoo.cfg: WARNING .* Killing chrome descendants-or-self .* (space-before-.*, permissive trailer).

…rning

Warning introduced in odoo/odoo@d22e0b4. Matches the pattern landed in OCA/web@c7fbf2d, OCA/server-ux@ca7dd94, OCA/social@b672f28, OCA/website@dce9ae7 and ~15 other OCA repos.

```
2026-05-16 09:00:07,221 306 WARNING odoo odoo.addons.resource_booking.tests.test_portal.PortalCase.test_portal_list_with_bookings: Killing chrome descendants-or-self of 323: 5 remaining
- chrome (zombie)
- chrome (zombie)
- chrome (zombie)
- chrome (zombie)
- chrome (zombie)
```
@dnplkndll
Copy link
Copy Markdown
Contributor Author

@pedrobaeza @victoralmau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant