[FIX] checklog-odoo.cfg: ignore Killing chrome descendants-or-self warning#218
Open
dnplkndll wants to merge 1 commit into
Open
[FIX] checklog-odoo.cfg: ignore Killing chrome descendants-or-self warning#218dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
…rning Warning introduced in odoo/odoo@d22e0b4. Matches the pattern landed in OCA/web@c7fbf2d, OCA/server-ux@ca7dd94, OCA/social@b672f28, OCA/website@dce9ae7 and ~15 other OCA repos. ``` 2026-05-16 09:00:07,221 306 WARNING odoo odoo.addons.resource_booking.tests.test_portal.PortalCase.test_portal_list_with_bookings: Killing chrome descendants-or-self of 323: 5 remaining - chrome (zombie) - chrome (zombie) - chrome (zombie) - chrome (zombie) - chrome (zombie) ```
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an ignore pattern to
checklog-odoo.cfgso the well-known chrome-zombie WARNING from Odoo's HttpCase tour cleanup does not promote passing test runs to CI failures.The pattern is verbatim the one already in use across the OCA org:
Plus ~16 other OCA repos with the same regex in their
checklog-odoo.cfg(helpdesk, pos, dms, mail, reporting-engine, l10n-brazil, e-commerce, connector-telephony, account-analytic, contract, edi-framework, oca-custom, stock-weighing, route-planning, rma, …).Why this matters for
OCA/calendarThe chrome-zombie WARNING (introduced in odoo/odoo@d22e0b4e) is emitted by Odoo's HttpCase test framework when headless-chrome renderer subprocesses don't exit cleanly after a tour test. The test outcomes themselves are reported on a separate line.
resource_booking(currently on 18.0, in the process of being migrated to 19.0 in #217) has multiple tour tests (test_portal_no_bookings,test_portal_list_with_bookings,test_portal_scheduling_conflict) that hit this every run. Without this ignore pattern, the CI failure log looks like:All 49 tests pass. The only "errors that caused failure" are the two chrome WARNINGs. With this PR's ignore pattern, those WARNINGs land in the "errors that did not cause failure" bucket (as they do in OCA/web, OCA/server-ux, OCA/social et al.) and CI goes green.
Verification
Cherry-picked the same one-line change onto #217's branch and re-ran CI: all 7 checks pass (
test with Odoo,test with OCB,pre-commit,codecov/patch,codecov/project,runboat/build,Detect unreleased dependencies). Plan to drop the equivalent commit from #217 once this PR merges so the MIG stays scope-clean.Test plan
Convention used
Same regex format as OCA/web's
checklog-odoo.cfg:WARNING .* Killing chrome descendants-or-self .*(space-before-.*, permissive trailer).