Skip to content

[19.0][MIG] purchase_container#3055

Open
theangryangel wants to merge 10 commits into
OCA:19.0from
GlodoUK:19.0-mig-purchase_container
Open

[19.0][MIG] purchase_container#3055
theangryangel wants to merge 10 commits into
OCA:19.0from
GlodoUK:19.0-mig-purchase_container

Conversation

@theangryangel
Copy link
Copy Markdown
Member

Standard migration bar 2 "issues":

  • weight_uom_id originally had a domain limiting to the weight uom category - this longer exists, so I've just erased it in absence of a better idea for the moment
  • uom_po_id no longer exists, I followed the upstream behaviour in moving to uom_id

@OCA-git-bot OCA-git-bot added series:19.0 mod:purchase_container Module purchase_container labels May 6, 2026
@theangryangel theangryangel mentioned this pull request May 6, 2026
78 tasks
@theangryangel theangryangel force-pushed the 19.0-mig-purchase_container branch from d569f8d to 15ba0cc Compare May 6, 2026 23:55
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to create a res.partner record when using BaseCommon, as it is already provided by the base class.

Comment thread purchase_container/tests/test_module.py Outdated
@theangryangel theangryangel force-pushed the 19.0-mig-purchase_container branch from 15ba0cc to 3f11547 Compare June 2, 2026 14:57
Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:purchase_container Module purchase_container series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants