Skip to content

[19.0][MIG] purchase_lot: Migration to 19.0#3071

Open
apami0111 wants to merge 36 commits into
OCA:19.0from
apami0111:19.0-mig-purchase_lot
Open

[19.0][MIG] purchase_lot: Migration to 19.0#3071
apami0111 wants to merge 36 commits into
OCA:19.0from
apami0111:19.0-mig-purchase_lot

Conversation

@apami0111
Copy link
Copy Markdown
Contributor

Migrates purchase_lot from 18.0 to 19.0.

The models and views required no changes.
Tests were updated to reflect Odoo 19.0 API changes in stock models
and to remove dependencies on demo data.

@apami0111 apami0111 force-pushed the 19.0-mig-purchase_lot branch from 902ac77 to 94bc6b5 Compare May 23, 2026 21:15
sebastienbeau and others added 27 commits May 23, 2026 16:25
Translated using Weblate (Spanish)

Currently translated at 100.0% (3 of 3 strings)

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_lot
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_lot/es/
Translated using Weblate (Italian)

Currently translated at 100.0% (3 of 3 strings)

Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_lot
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_lot/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_lot
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_lot/
Currently translated at 100.0% (5 of 5 strings)

Translation: purchase-workflow-17.0/purchase-workflow-17.0-purchase_lot
Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-17-0/purchase-workflow-17-0-purchase_lot/it/
Copy link
Copy Markdown

@Yoana-RB Yoana-RB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM :)

Copy link
Copy Markdown
Contributor

@celm1990 celm1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the administrative commits

Comment on lines +103 to +111
(
0,
0,
{
"product_id": self.large_cabinet.id,
"product_qty": 1.0,
"lot_id": self.lot1.id,
},
)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(
0,
0,
{
"product_id": self.large_cabinet.id,
"product_qty": 1.0,
"lot_id": self.lot1.id,
},
)
Command.create(
{
"product_id": self.large_cabinet.id,
"product_qty": 1.0,
"lot_id": self.lot1.id,
},
)

Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when using BaseCommon, there’s no need to create a res.partner record manually.

@classmethod
def setUpClass(cls):
super().setUpClass()
cls.partner_id = cls.env["res.partner"].create({"name": "Test Supplier"})
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cls.partner_id = cls.env["res.partner"].create({"name": "Test Supplier"})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.