[18.0][ADD] purchase_order_line_desc_wo_product_code:#3072
Closed
cgarcia-solvos wants to merge 1 commit into
Closed
[18.0][ADD] purchase_order_line_desc_wo_product_code:#3072cgarcia-solvos wants to merge 1 commit into
cgarcia-solvos wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:18.0
mod:purchase_order_line_desc_wo_product_code
cgarcia-solvos
force-pushed
the
18.0-add-purchase_order_line_desc_wo_product_code
branch
2 times, most recently
from
90c01f4 to
2b8a2bc
Compare
Avoid duplicated product codes in purchase order line descriptions
cgarcia-solvos
force-pushed
the
18.0-add-purchase_order_line_desc_wo_product_code
branch
from
2b8a2bc to
771ddfc
Compare
Contributor
Author
|
@ivantodorovich @marcelsavegnago hi, could you review this? Thanks!! |
Contributor
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
The purchase_order_line_desc_wo_product_code module is not working according to its specifications.
I have attached a video demonstrating the incorrect workflow. Please review it and fix the issue.
purchase_order_line_desc_wo_product_code_3072_PR.mp4
Contributor
Author
|
@BhaveshHeliconia Thanks for the review! You're right. Since Odoo core was updated to make product descriptions editable in Purchase Orders (odoo/odoo@b48e1e2), this addon is no longer necessary. I'll close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid duplicated product codes in purchase order line descriptions