[19.0][ADD] purchase_auto_bill_on_receipt#3075
Open
AungKoKoLin1997 wants to merge 1 commit into
Open
Conversation
OCA-git-bot
added
series:19.0
mod:purchase_auto_bill_on_receipt
AungKoKoLin1997
force-pushed
the
19.0-add-purchase_auto_bill_on_receipt
branch
from
bd429fd to
e97aff1
Compare
smorita7749
reviewed
Jun 4, 2026
smorita7749
approved these changes
Jun 4, 2026
smorita7749
left a comment
smorita7749
left a comment
There was a problem hiding this comment.
Code and functional review: LGTM
yostashiro
suggested changes
Jun 6, 2026
AungKoKoLin1997
force-pushed
the
19.0-add-purchase_auto_bill_on_receipt
branch
from
e97aff1 to
102a01f
Compare
yostashiro
suggested changes
Jun 8, 2026
| picking._auto_create_vendor_bill() | ||
| return res | ||
|
|
||
| def _auto_create_vendor_bill(self): |
Member
There was a problem hiding this comment.
Can we move this above buttom_validate?
|
|
||
| block_auto_bill = fields.Boolean( | ||
| help="When enabled, suppresses automatic bill creation on receipt " | ||
| "for this order, regardless of product or category settings.", |
Member
There was a problem hiding this comment.
Please update this to reflect the recent change.
Comment on lines
+40
to
+59
| try: | ||
| bill = self._auto_bill_create(picking, eligible_lines) | ||
| except Exception as e: | ||
| _logger.exception( | ||
| "Auto-bill creation failed for PO %s / picking %s", | ||
| self.name, | ||
| picking.name, | ||
| ) | ||
| self._auto_bill_log_failure(picking, "create", e) | ||
| return self.env["account.move"] | ||
| try: | ||
| bill.action_post() | ||
| except Exception as e: | ||
| _logger.exception( | ||
| "Auto-bill posting failed for PO %s / picking %s / bill %s", | ||
| self.name, | ||
| picking.name, | ||
| bill.name, | ||
| ) | ||
| self._auto_bill_log_failure(picking, "post", e, bill=bill) |
Member
There was a problem hiding this comment.
Try handling these steps with cron + _trigger() instead.
Comment on lines
+32
to
+37
| received_products = picking.move_ids.product_id | ||
| eligible_lines = self.order_line.filtered( | ||
| lambda line: line.product_id in received_products | ||
| and line.product_id.purchase_method == "receive" | ||
| and line.qty_to_invoice > 0 | ||
| ) |
Member
There was a problem hiding this comment.
Suggested change
| received_products = picking.move_ids.product_id | |
| eligible_lines = self.order_line.filtered( | |
| lambda line: line.product_id in received_products | |
| and line.product_id.purchase_method == "receive" | |
| and line.qty_to_invoice > 0 | |
| ) | |
| eligible_lines = picking.move_ids.purchase_line_id.filtered( | |
| lambda line.product_id.purchase_method == "receive" | |
| and line.qty_to_invoice > 0 | |
| ) |
| invoice_lines.append(Command.create(section_vals)) | ||
| sequence += 1 | ||
| pending_section = None | ||
| line_vals = line._prepare_account_move_line() |
Member
There was a problem hiding this comment.
Can we get qty from the linked picking and set it here? I think there might be cases where multiple receipts are consolidated into one bill under the current design.
qty = self._get_picking_line_qty(picking, line)
if not qty:
continue
line_vals["quantity"] = qty_get_picking_line_qty doesn't exist, so please add it.
AungKoKoLin1997
force-pushed
the
19.0-add-purchase_auto_bill_on_receipt
branch
from
102a01f to
2e4edf2
Compare
AungKoKoLin1997
force-pushed
the
19.0-add-purchase_auto_bill_on_receipt
branch
from
2e4edf2 to
1eb0690
Compare
yostashiro
reviewed
Jun 8, 2026
Comment on lines
+89
to
+91
| line_vals["sequence"] = sequence | ||
| line_vals["quantity"] = qty | ||
| invoice_lines.append(Command.create(line_vals)) |
Member
There was a problem hiding this comment.
Very minor point but should be in this order.
Suggested change
| line_vals["sequence"] = sequence | |
| line_vals["quantity"] = qty | |
| invoice_lines.append(Command.create(line_vals)) | |
| line_vals["quantity"] = qty | |
| invoice_lines.append(Command.create(line_vals)) | |
| line_vals["sequence"] = sequence |
|
|
||
| def _cron_auto_bill(self): | ||
| for picking in self.search([("auto_bill_pending", "=", True)]): | ||
| picking._auto_create_vendor_bill() |
Member
There was a problem hiding this comment.
To be safe.
Suggested change
| picking._auto_create_vendor_bill() | |
| try: | |
| with self.env.cr.savepoint(): | |
| picking._auto_create_vendor_bill() | |
| except Exception: | |
| _logger.exception(...) |
| self.ensure_one() | ||
| invoice_vals = self._prepare_invoice() | ||
| invoice_vals["invoice_date"] = fields.Date.context_today( | ||
| self, picking.date_done |
Member
There was a problem hiding this comment.
Now that it's run by cron user, let's use the timezone of the company's partner. Please document it in the readme as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module automatically creates and posts a Vendor Bill when a purchase receipt is validated.
@qrtl QT6796