[18.0][FIX] purchase_allowed_product: avoid parent in line form#3082
Merged
OCA-git-bot merged 1 commit intoJun 8, 2026
Merged
Conversation
OCA-git-bot
added
series:18.0
mod:purchase_allowed_product
pedrobaeza
requested changes
Jun 1, 2026
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
OK for changing parent to move_id, but please don't add a test that is not adding value.
fsmw
force-pushed
the
18.0-fix-purchase-allowed-product-parent-context
branch
from
8d23dba to
7a466b8
Compare
Contributor
Author
|
@pedrobaeza thanks for the review — done. Dropped the new test in 7a466b8; only the XML fix remains. Could you re-review when you have a moment? |
pedrobaeza
approved these changes
Jun 4, 2026
Contributor
|
This PR has the |
Member
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at f1b9bc3. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the standalone form crash in when the field context is evaluated without an x2many parent scope.
Cause
Solution
Refs #3070