itr_chip drivers: dt_driver resources for interrupts bindings - #6088
Merged
Conversation
Defines identifier DT_DRIVER_INTERRUPT in dt_driver_type enumerated type for interrupt controller drivers. Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
jenswikl
reviewed
Jun 7, 2023
| } | ||
|
|
||
| prop_index *= dt_driver_provider_cells(prv); | ||
| if (prop_index * sizeof(*prop) >= (size_t)len) { |
Contributor
There was a problem hiding this comment.
Woulnd't
(prop_index + 1) * sizeof(*prop) > (size_t)lenbe more accurate?
Contributor
Author
There was a problem hiding this comment.
you're right. Thanks.
Contributor
Author
|
comment addressed |
Contributor
|
|
Adds a helper function dt_driver_device_from_node_idx_prop_phandle() in device tree driver probing framework for when a DT node property contains a resource references but not the related device phandle as first property cell, as for property "interrupts" which should get the interrupt controller phandle from property "interrupt-parent". This change aims at supporting "interrupts" property DT bindings. Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Contributor
Author
|
fixup commit squashed and tag applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 patches extracted from #5954:
"core: dt_driver: define interrupt controller drivers identifier":
@jenswi-linaro review tag applied (#5954 (comment)).
"core: dt_driver: add helper for old fashion interrupt bindings"
@jenswi-linaro review tag (#5954 (review)) is NOT YET applied as I squashed in a fix (#5954 (comment)).