core: interrupt: new interrupt API functions - #6096
Merged
Merged
Conversation
Contributor
Author
|
I forgot to mention that commit "core: interrupt: core controller uses irq_chip list head" was reviewed through #5954 so I preserved @jenswi-linaro applied review tag. |
Contributor
Author
|
Oups, I missed to add the gic/hfic/saic updata patches to provide mask/unmask handlers, hence why CI failed when running Qemu. I'll force push the series. |
Contributor
Author
|
|
borneoa
suggested changes
Jun 7, 2023
borneoa
left a comment
borneoa
left a comment
There was a problem hiding this comment.
Few typos and some suggest for consistency
| * interrupt_configure() - Configure an interrupt in an interrupt controller | ||
| * @chip Interrupt controller | ||
| * @itr_num Interrupt number | ||
| * @type Trigger type ITR_TYPE_* of ITR_TYPE_NONE |
There was a problem hiding this comment.
s/of/or/ ?
Probably copy-paste the description from next API interrupt_configure(); it's more clear and keeps consistency. Also copy-paste for next argument "prio"
| * @type Trigger type ITR_TYPE_* of ITR_TYPE_NONE | ||
| * @prio Interrupt priority | ||
| * | ||
| * Interrupt consumer that get their interrupt from the DT do not need to |
| * interrupt_add_handler() - Register an interrupt handler | ||
| * @hdl Interrupt handler to register | ||
| * | ||
| * This helper function assumes interrypt type is set to IRQ_TYPE_NONE |
| * interrupt_alloc_add_handler() - Allocate and register an interrupt handler | ||
| * @chip Interrupt controller | ||
| * @itr_num Interrupt number | ||
| * @handler Handler function |
There was a problem hiding this comment.
For consistency, "Interrupt handler to register" ?
Contributor
Author
|
Comments addressed. Thanks @borneoa for the review. |
jenswikl
reviewed
Jun 8, 2023
| */ | ||
| static inline void interrupt_enable(struct itr_chip *chip, size_t itr_num) | ||
| { | ||
| if (chip->ops->enable) |
Contributor
There was a problem hiding this comment.
Didn't we agree on making these mandatory?
Contributor
Author
There was a problem hiding this comment.
Why not make this function pointer mandatory? Same for the other ops below.
Right, I missed the last sentence, sorry. Ok to make also .enable/.disable mandatory.
Contributor
Author
|
comment addressed |
Contributor
|
|
Extends itr_chip framework to allow interrupt controllers to register as interrupt chip and other interrupt management methods it their owns interrupt consumer through the interrupt_xxx() API function. This change does not modify the existing interrupt API function that allow a driver to get an interrupt from the CPU main interrupt controller. A later change will remove these old API functions. This changes adds fields in existing structures defined in interrupt.h: - itr_handler::chip back references the interrupt controller - itr_chip::handlers is a list head for controller registered handlers - itr_chip::name for debug trace purpose - itr_ops::mask and itr_ops::unmask to mask/unmask an interrupt The new API functions exposed to interrupt consumers are: - interrupt_add_configure_handler(), interrupt_remove_handler() and helper functions interrupt_add_handler() and interrupt_add_handler_with_chip(); - interrupt_alloc_add_handler() and interrupt_remove_free_handler(); - interrupt_configure(), interrupt_enable(), interrupt_disable(), interrupt_mask() and interrupt_unmask(); Interrupt controllers shall call generic API function interrupt_call_handlers() to have their registered consumer handlers called upon their related interrupt occurrences. Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Implements GIC interrupts mask/unmask operation handlers using interrupt disable/enable operation handlers. Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Implements Atmel SAIC interrupts mask/unmask operation handlers using interrupt disable/enable operation handlers. This change is needed as mask/unmask operation handlers are required by the new native interrupt framework. Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Implements Hafnium interrupts mask/unmask operation handlers using interrupt disable/enable operation handlers. This change is needed as mask/unmask operation handlers are required by the new native interrupt framework. Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Changes core interrupt controller API function (from interrupt.c) to use the handlers list head added in struct itr_handler instead of local list head. With this change, main itr_chip is managed as a standard itr_chip and its interrupts can be fetched from the irq_chip handler functions. CPU primary interrupt handler itr_handle() function now calls generic interrupt controller interrupt_call_handlers(). Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Contributor
Author
|
Thanks for the review and help. |
This was referenced Oct 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5 patches etracted from #5954 + a fixup patch (for an added change not proposed in that reference P-R: sanity test on pageable attribute of interrupt handling resources) to propose new interrupt management API functions that can be used on CPU main interrupt controller as well as on secondary interrupt controllers.