core interrupt: use device tree data by etienne-lms · Pull Request #6361 · OP-TEE/optee_os

etienne-lms · 2023-10-10T14:25:48Z

Following changes done recently in the interrupt framework, this P-R is based on #6097. It provides means to use DT bindings to describe interrupts and their controllers.

2nd commit adds an API function (dt_register_interrupt_provider())for interrupt controller drivers to register as itr_chip providers into the DT_DRIVER framework and few API functions for consumer driver to use DT info to find their interrupt (interrupt_dt_get(), interrupt_dt_get_by_index(), interrupt_dt_get_by_name()).

3rd commit Adds a API function to register a callback handler for an interrupt.
interrupt_create_handler() differs from existing interrupt_add_handler() in that the former does not reconfigure the interrupt since already done by interrupt_dt_get() or friend. Maybe interrupt_add_handler2() would be a better label.

Last commit registers GIC driver as a DT_DRIVER_INTERRUPT driver so that interrupt consumer drivers can use interrupt_dt_get_by_index() and friends.

jenswikl · 2023-10-12T06:52:34Z

Once you're done with the initial preparations of the PR, please squash in the fixups.

etienne-lms · 2023-10-12T09:20:24Z

I've squashed the fixup commits.

jforissier

One small comment for "core: interrupt: registering interrupt providers", with or without it:

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

jforissier

"core: dt_driver: don't enforce phandle 1st arg is a phandle":

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

jforissier

"core: interrupt: add interrupt_create_handler()":

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

jforissier

"drivers: gic: register to dt_driver":

Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

jforissier

"drivers: gic: use DT bindings":

Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>

etienne-lms · 2023-10-31T10:43:22Z

#6361 (comment) addressed.
Tags applied.
Thanks for the review.

I've created a P-R in optee_docs for these new API functions: OP-TEE/optee_docs#218.

jforissier · 2023-10-31T10:50:55Z

Please rebase onto master to fix the IBART error, thanks!

etienne-lms · 2023-10-31T11:37:14Z

right, thanks.

etienne-lms · 2023-10-31T12:50:01Z

rebased

etienne-lms · 2023-10-31T12:58:38Z

Arrg! IBART still fails.

jforissier · 2023-10-31T13:14:00Z

Arrg! IBART still fails.

Memory allocation error. Maybe a larger CFG_CORE_HEAP_SIZE is needed. Unfortunately not easy to change since the IBART config is not in this project.

etienne-lms · 2023-10-31T13:17:31Z

I did not expect this change would make such platforms to consume more heap. IBART does not use DT for OP-TEE drivers inits.

etienne-lms · 2023-11-03T14:20:59Z

Comment addressed.

etienne-lms · 2023-11-06T15:05:16Z

oups... needs some rebasing.

etienne-lms · 2023-11-06T15:08:10Z

rebased.

jenswikl · 2023-11-07T07:10:56Z

If "core: kernel: dt_driver: reference output device reference as void *" was possible before, why did we ever have pointer-pointers as arguments to those functions?

etienne-lms · 2023-11-07T08:31:30Z

My bad. The several driver frameworks use struct clk **, struct rstctrl **, struct regulator **, etc... hence I chose void ** generic type in core/kernel/dt_driver.c to represent that (see commit b357d34) in the generic functions the several device frameworks rely on. Maybe a bad idea, I could have used void * at the time.

Note I will place commit "core: kernel: dt_driver: reference output device reference as void *" at the beginning of the series when I will squash the fixup commits.

jenswikl · 2023-11-07T09:25:25Z

Feel free to squash the fixup commits now. I'll take another look once it's done.

etienne-lms · 2023-11-07T10:16:25Z

I've squashed the fixup commits and reordered the series.

@jforissier, I removed your A-b tag from commits "core: interrupt: registering interrupt providers"
and "drivers: gic: register to dt_driver" as content sligthly changed since you reviewed them.

jenswikl · 2023-11-08T08:24:15Z

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

jforissier · 2023-11-08T09:04:46Z

I've squashed the fixup commits and reordered the series.

@jforissier, I removed your A-b tag from commits "core: interrupt: registering interrupt providers" and "drivers: gic: register to dt_driver" as content sligthly changed since you reviewed them.

Acked-by: Jerome Forissier <jerome.forissier@linaro.org> for both, thanks.

etienne-lms · 2023-11-08T11:05:00Z

@jbech-linaro, could you help me understand why IBART fails with this series? #6361 (comment) mentions a core heap exhaustion but since the platform used by IBART does not embed any secure DTB, I don't understand why these changes make the platform to consume more core heap.

(edited)

etienne-lms · 2023-11-08T11:05:48Z

I forgot to mention that i've applied the review tags.

jockebech · 2023-11-20T09:28:18Z

As discussed in email. I've been able to reproduce the error on two difference machines. So, although I don't now that causes it, it at least seems reproducible.

@prop

Changes local function device_from_provider_prop() to assume its argument @prop points to the first argument to pass with phandle. This change allows a later change to support other DT bindings ("interrupts" property) where 1st cell of the property is not a phandle but the 1st phandle argument to be passed. Acked-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>

Changes dt_driver API function to reference device reference as void * instead of void ** which could be confusing as the reference can be a pointer to a device pointer (e.g. in clk_dt.c) or a pointer to a structure (e.g. interrupt.c). Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>

Adds interrupt chip framework API functions for an interrupt controller to register as an interrupt provider in the driver probing sequence based on device tree. This allows interrupt consumer to be deferred when a dependent interrupt controller is not yet initialized. Interrupt controllers register a driver in DT_DRIVER providers list with: interrupt_register_provider(). Interrupt consumer can get their interrupt through DT data with interrupt_dt_get(), interrupt_dt_get_by_index() or interrupt_dt_get_by_name(). This change removes inclusion of interrupt.h from kernel/dt.h as it is not needed and conflicts with inclusion of kernel/dt.h from kernel/interrupt.h. Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>

Adds interrupt_create_handler() API function in interrupt framework. The function is to be used with interrupt controls obtained from the DT with interrupt_dt_get() interrupt_dt_get_by_index() or interrupt_dt_get_by_name(). The function differs from legacy interrupt_add_handler() in that this latter always reconfigure the interrupt while new interrupt_create_handler() function assumes the interrupt was configured from interrupt_dt_get() or friends. Acked-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>

Registers GIC driver as an interrupt controller in DT_DRIVER providers when DT is supported. This change allows interrupt consumer nodes to leverage interrupts and interrupts-extended properties DT bindings for their device drivers to retrieve their interrupts. Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>

Use DT bindings GIC_PPI and GIC_SIP instead of 1 and 0 raw values. Acked-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>

etienne-lms · 2023-11-21T21:36:31Z

IBART CI test failure should be fixed by OP-TEE/optee_test#711.

etienne-lms · 2023-11-22T10:05:27Z

IBART's happy!

etienne-lms commented Oct 10, 2023

View reviewed changes

Comment thread core/drivers/gic.c Outdated

etienne-lms mentioned this pull request Oct 11, 2023

core: using native interrupt handlers OP-TEE/optee_docs#215

Merged

etienne-lms force-pushed the itr-chip-2-dt branch from 77499da to 4eb3dc3 Compare October 12, 2023 07:56

jforissier reviewed Oct 23, 2023

View reviewed changes

Comment thread core/include/kernel/interrupt.h Outdated

jforissier reviewed Oct 23, 2023

View reviewed changes

etienne-lms force-pushed the itr-chip-2-dt branch from 4eb3dc3 to 16df82c Compare October 31, 2023 10:36

etienne-lms mentioned this pull request Oct 31, 2023

core: native interrupt using DT bindings OP-TEE/optee_docs#218

Closed

etienne-lms force-pushed the itr-chip-2-dt branch from 16df82c to 5755be4 Compare October 31, 2023 11:38

jenswikl reviewed Nov 3, 2023

View reviewed changes

Comment thread core/kernel/interrupt.c Outdated

jenswikl reviewed Nov 6, 2023

View reviewed changes

Comment thread core/drivers/gic.c Outdated

etienne-lms force-pushed the itr-chip-2-dt branch from a528603 to 7bddbfd Compare November 6, 2023 15:08

etienne-lms force-pushed the itr-chip-2-dt branch from 7bddbfd to eac12f4 Compare November 7, 2023 10:14

etienne-lms force-pushed the itr-chip-2-dt branch 2 times, most recently from 257be21 to bb1d48a Compare November 8, 2023 09:33

etienne-lms force-pushed the itr-chip-2-dt branch from bb1d48a to 9e8ef57 Compare November 15, 2023 20:09

jockebech mentioned this pull request Nov 20, 2023

FF-A Notifications #6394

Merged

etienne-lms added 6 commits November 21, 2023 14:54

drivers: gic: use DT bindings

9a670cd

Use DT bindings GIC_PPI and GIC_SIP instead of 1 and 0 raw values. Acked-by: Jerome Forissier <jerome.forissier@linaro.org> Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com>

etienne-lms force-pushed the itr-chip-2-dt branch from f9bd1e0 to 9a670cd Compare November 21, 2023 13:55

jforissier merged commit 8c7282b into OP-TEE:master Nov 22, 2023

etienne-lms deleted the itr-chip-2-dt branch January 8, 2025 08:06

Uh oh!

Conversation

etienne-lms commented Oct 10, 2023

Uh oh!

Uh oh!

jenswikl commented Oct 12, 2023

Uh oh!

etienne-lms commented Oct 12, 2023

Uh oh!

jforissier left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jforissier left a comment

Choose a reason for hiding this comment

Uh oh!

jforissier left a comment

Choose a reason for hiding this comment

Uh oh!

jforissier left a comment

Choose a reason for hiding this comment

Uh oh!

jforissier left a comment

Choose a reason for hiding this comment

Uh oh!

etienne-lms commented Oct 31, 2023

Uh oh!

jforissier commented Oct 31, 2023

Uh oh!

etienne-lms commented Oct 31, 2023

Uh oh!

etienne-lms commented Oct 31, 2023

Uh oh!

etienne-lms commented Oct 31, 2023

Uh oh!

jforissier commented Oct 31, 2023

Uh oh!

etienne-lms commented Oct 31, 2023

Uh oh!

Uh oh!

etienne-lms commented Nov 3, 2023

Uh oh!

Uh oh!

etienne-lms commented Nov 6, 2023

Uh oh!

etienne-lms commented Nov 6, 2023

Uh oh!

jenswikl commented Nov 7, 2023

Uh oh!

etienne-lms commented Nov 7, 2023

Uh oh!

jenswikl commented Nov 7, 2023

Uh oh!

etienne-lms commented Nov 7, 2023

Uh oh!

jenswikl commented Nov 8, 2023

Uh oh!

jforissier commented Nov 8, 2023

Uh oh!

etienne-lms commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

etienne-lms commented Nov 8, 2023

Uh oh!

jockebech commented Nov 20, 2023

Uh oh!

etienne-lms commented Nov 21, 2023

Uh oh!

etienne-lms commented Nov 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

etienne-lms commented Nov 8, 2023 •

edited

Loading