regression: add tests for the supplicant plugin framework - #482
Conversation
| } | ||
|
|
||
| struct plugin_method plugin_method = { | ||
| "test", |
There was a problem hiding this comment.
Please name the fields you're initializing. The NULL below can be skippen then also.
9c640ad to
630c8e2
Compare
|
All comments have been addressed |
| TEEC_NONE); | ||
|
|
||
| ADBG_EXPECT_TEEC_SUCCESS(c, TEEC_InvokeCommand(&session, | ||
| TA_SUPP_PLUGIN_PASS_VALUES, &op, |
There was a problem hiding this comment.
You're aligning with wrong (
This comment applies to a few places below too.
| #define TA_SUPP_PLUGIN_TEST_UUID { 0x380231ac, 0xfb99, 0x47ad, \ | ||
| { 0xa6, 0x89, 0x9e, 0x01, 0x7e, 0xb6, 0xe7, 0x8a } } | ||
|
|
||
| #define TA_SUPP_PLUGIN_PING 0 |
There was a problem hiding this comment.
Please rename these TA commands as TA_SUPP_PLUGIN_CMD_*
| #ifndef TA_SUPP_PLUGIN_TEST_H | ||
| #define TA_SUPP_PLUGIN_TEST_H | ||
|
|
||
| #define TA_SUPP_PLUGIN_TEST_UUID { 0x380231ac, 0xfb99, 0x47ad, \ |
There was a problem hiding this comment.
Please rename to TA_SUPP_PLUGIN_UUID, the TEST part is redundant.
Please drop the _test part from the name of this file too.
|
|
||
| /* | ||
| * TA will ping the test plugin during open session operation. | ||
| * Supplicant plugins are optional: warn and nicely exit if not found |
There was a problem hiding this comment.
Optional? I can't see that in OP-TEE/optee_client#239
| return tee_invoke_supp_plugin(&nulluuid, 0, 0, data, inlen, NULL); | ||
| } | ||
|
|
||
| TEE_Result TA_InvokeCommandEntryPoint(void *pSessionContext __unused, |
There was a problem hiding this comment.
All these TA functions could be replaced by a single TA function (the os_test TA would be a good match then) with a flexible interface allowing to put most of the logic in xtest. If you'd rather keep it as is that's fine too.
There was a problem hiding this comment.
I'd prefer to keep it as it is, thanks
|
All comments have been addressed |
|
|
Add test cases for checking functionality of supplicant plugins: - Ability to pass values and arrays to/from a plugin - Right handle situations with bad input parameters - Right handle situations with calling an unknown plugin Signed-off-by: Aleksandr Anisimov <a.anisimov@omprussia.ru> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
80204b0 to
f77a9de
Compare
|
Squashed the fixup commits and updated the commit message. |
|
IBART is passing, all good! Thanks @anisyanka. |
3 participants
Add test cases for checking functionalitu of supplicant plugins:
Signed-off-by: Aleksandr Anisimov a.anisimov@omprussia.ru