Skip to content

Fixed timer leaks in ChannelAsyncOperation.EndAsync (#3669) - #4166

Open
KarenKrill wants to merge 9 commits into
OPCFoundation:master378from
steklabs:release/1.5.378
Open

Fixed timer leaks in ChannelAsyncOperation.EndAsync (#3669)#4166
KarenKrill wants to merge 9 commits into
OPCFoundation:master378from
steklabs:release/1.5.378

Conversation

@KarenKrill

Copy link
Copy Markdown
Contributor

Fixed timer leaks in ChannelAsyncOperation.EndAsync

Proposed changes

  • Added linked cancellation token source for delay task (runtimes <= .NET 6.0)
  • Added delay task cancellation (runtimes <= .NET 6.0)

Related Issues

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

Fix already accepted in master branch, please add it to latest 1.5.378 version

mrsuciu and others added 9 commits December 18, 2025 09:36
Update version from 1.5.378-preview to 1.5.378
* Fixed timer leaks in ChannelAsyncOperation.EndAsync (added delay task cancellation)

* Added WaitAsync with timeout PolyFill extension for versions <= .NET 6.0

* The ChannelAsyncOperation.EndAsync has been unified across all .NET versions using polyfills for older versions (< .NET 6.0)

* Fixed missing "using" operator
# Description

Prepare 1.5.378 maintenence release


## Checklist

_Put an `x` in the boxes that apply. You can complete these step by step
after opening the PR._

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [ ] I have added all necessary documentation.
- [ ] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
# Description

Prepare 1.5378 maintenance  release  

## Checklist

_Put an `x` in the boxes that apply. You can complete these step by step
after opening the PR._

- [ ] I have signed the
[CLA](https://opcfoundation.org/license/cla/ContributorLicenseAgreementv1.0.pdf)
and read the
[CONTRIBUTING](https://github.com/OPCFoundation/UA-.NETStandard/blob/master/CONTRIBUTING.md)
doc.
- [ ] I have added tests that prove my fix is effective or that my
feature works and increased code coverage.
- [ ] I have added all necessary documentation.
- [ ] I have verified that my changes do not introduce (new) build or
analyzer warnings.
- [ ] I ran **all** tests locally using the **UA.slnx** solution against
at least .net **framework** and .net **10**, and all passed.
- [ ] I fixed **all** failing and flaky tests in the CI pipelines and
**all** CodeQL warnings.
- [ ] I have addressed **all** PR feedback received.
@marcschier

Copy link
Copy Markdown
Collaborator

@KarenKrill please target master378 branch, not release/1.5.378. I will take care of the other PR which I accidently merged.

@marcschier marcschier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target master378 branch.

@marcschier marcschier added needs changes PR needs more changes 1.5.378 Only affects 1.5.378 (pre 2.0) labels Aug 3, 2026
@romanett
romanett changed the base branch from release/1.5.378 to master378 August 3, 2026 08:04
@romanett
romanett dismissed marcschier’s stale review August 3, 2026 08:04

target branch changed

@romanett romanett added ready Ready to merge once CI Passes and removed needs changes PR needs more changes labels Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.5.378 Only affects 1.5.378 (pre 2.0) ready Ready to merge once CI Passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants