fix: replace deprecated NSKeyedArchiver/NSKeyedUnarchiver APIs#1680
Open
garvitkaushik-123 wants to merge 1 commit into
Open
fix: replace deprecated NSKeyedArchiver/NSKeyedUnarchiver APIs#1680garvitkaushik-123 wants to merge 1 commit into
garvitkaushik-123 wants to merge 1 commit into
Conversation
…odern equivalents The deprecated `+[NSKeyedUnarchiver unarchiveObjectWithData:]` and `+[NSKeyedArchiver archivedDataWithRootObject:]` methods are flagged as unsafe by security scanners (CWE-676). Replace them with instance-based `NSKeyedUnarchiver` and `archivedDataWithRootObject:requiringSecureCoding:error:` which are available since iOS 11.0 (the SDK minimum deployment target). Resolves OneSignal#919
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+[NSKeyedUnarchiver unarchiveObjectWithData:]with instance-basedNSKeyedUnarchiverusinginitForReadingFromData:error:anddecodeTopLevelObjectAndReturnError:+[NSKeyedArchiver archivedDataWithRootObject:]witharchivedDataWithRootObject:requiringSecureCoding:NO error:The deprecated methods are flagged as unsafe by security scanners (CWE-676). Setting
requiresSecureCoding = NOmaintains backward compatibility with existing model classes that implementNSCoding.Resolves #919
Test plan
NSKeyedArchiver/NSKeyedUnarchiverin build output