Repository navigation
freertos: Avoid timestamp overflow before widening - #371
Open
bentheredonethat wants to merge 1 commit into
Open
bentheredonethat wants to merge 1 commit into
bentheredonethat wants to merge 1 commit into
Conversation
metal_get_timestamp() returns a 64-bit microsecond timestamp, but on Cortex-R5 FreeRTOS it multiplies the 32-bit tick count in 32-bit arithmetic before widening the result. At 100 Hz, timestamps wrap after 429496 ticks. Widen the tick count first and convert with configTICK_RATE_HZ. This also avoids portTICK_PERIOD_MS truncation for tick rates that do not divide 1000 evenly. Assisted-by: Codex:Claude-Opus-5.5 coverity Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
arnopo
requested review from
a team,
arnopo,
edmooring and
tnmysh
and removed request for
a team
October 22, 2026 07:20
arnopo
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metal_get_timestamp() returns a 64-bit microsecond timestamp, but on Cortex-R5 FreeRTOS it multiplies the 32-bit tick count in 32-bit arithmetic before widening the result. At 100 Hz, timestamps wrap after 429496 ticks.
Widen the tick count first and convert with configTICK_RATE_HZ. This also avoids portTICK_PERIOD_MS truncation for tick rates that do not divide 1000 evenly.